Skip to content

Commit 3998906

Browse files
authored
fix(material/slider): avoid manual fixing values on pointer up (#26215)
* fix(material/slider): avoid manual fixing values on pointer up * Fixes issue #26172 * fixup! fix(material/slider): avoid manual fixing values on pointer up * fixup! fix(material/slider): avoid manual fixing values on pointer up * fixup! fix(material/slider): avoid manual fixing values on pointer up
1 parent 1cc831c commit 3998906

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

src/material/slider/slider-input.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -439,12 +439,11 @@ export class MatSliderThumb implements _MatSliderThumb, OnDestroy, ControlValueA
439439
}
440440
}
441441

442-
_onPointerUp(event: PointerEvent): void {
442+
_onPointerUp(): void {
443443
this._isActive = false;
444-
this._updateWidthInactive();
445-
if (!this.disabled) {
446-
this._handleValueCorrection(event);
447-
}
444+
setTimeout(() => {
445+
this._updateWidthInactive();
446+
});
448447
}
449448

450449
_clamp(v: number): number {
@@ -636,11 +635,13 @@ export class MatSliderRangeThumb extends MatSliderThumb implements _MatSliderRan
636635
super._onPointerDown(event);
637636
}
638637

639-
override _onPointerUp(event: PointerEvent): void {
640-
super._onPointerUp(event);
638+
override _onPointerUp(): void {
639+
super._onPointerUp();
641640
if (this._sibling) {
642-
this._sibling._updateWidthInactive();
643-
this._sibling._hostElement.classList.remove('mat-mdc-slider-input-no-pointer-events');
641+
setTimeout(() => {
642+
this._sibling!._updateWidthInactive();
643+
this._sibling!._hostElement.classList.remove('mat-mdc-slider-input-no-pointer-events');
644+
});
644645
}
645646
}
646647

tools/public_api_guard/material/slider.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export class MatSliderRangeThumb extends MatSliderThumb implements _MatSliderRan
167167
// (undocumented)
168168
_onPointerMove(event: PointerEvent): void;
169169
// (undocumented)
170-
_onPointerUp(event: PointerEvent): void;
170+
_onPointerUp(): void;
171171
// (undocumented)
172172
_setIsLeftThumb(): void;
173173
// (undocumented)
@@ -243,7 +243,7 @@ export class MatSliderThumb implements _MatSliderThumb, OnDestroy, ControlValueA
243243
// (undocumented)
244244
_onPointerMove(event: PointerEvent): void;
245245
// (undocumented)
246-
_onPointerUp(event: PointerEvent): void;
246+
_onPointerUp(): void;
247247
get percentage(): number;
248248
registerOnChange(fn: any): void;
249249
registerOnTouched(fn: any): void;

0 commit comments

Comments
 (0)