chore: enable strict apply, bind, and call (#18172)

(cherry picked from commit 26962a7)

Author: mmalerba

src/bazel-tsconfig-build.json

@@ -18,6 +18,7 @@
     "noImplicitAny": true,
     "noImplicitThis": true,
     "importHelpers": true,
+    "strictBindCallApply": true,
     "newLine": "lf",
     "module": "es2015",
     "moduleResolution": "node",

src/cdk/a11y/key-manager/list-key-manager.spec.ts

@@ -33,7 +33,9 @@ class FakeQueryList<T> extends QueryList<T> {
   set length(_) { /* Empty setter for base class constructor */  }
   get first() { return this.items[0]; }
   toArray() { return this.items; }
-  some() { return this.items.some.apply(this.items, arguments); }
+  some(...args: [(value: T, index: number, array: T[]) => unknown, any?]) {
+    return this.items.some(...args);
+  }
   notifyOnChanges() { this.changes.next(this); }
 }
 

src/cdk/drag-drop/directives/drag.spec.ts

@@ -1842,14 +1842,22 @@ describe('CdkDrag', () => {
           body: document.body,
           fullscreenElement: document.createElement('div'),
           ELEMENT_NODE: Node.ELEMENT_NODE,
-          querySelectorAll: function() {
-            return document.querySelectorAll.apply(document, arguments);
+          querySelectorAll: function(...args: [string]) {
+            return document.querySelectorAll(...args);
           },
-          addEventListener: function() {
-            document.addEventListener.apply(document, arguments);
+          addEventListener: function(...args: [
+              string,
+              EventListenerOrEventListenerObject,
+              (boolean | AddEventListenerOptions | undefined)?
+          ]) {
+            document.addEventListener(...args);
           },
-          removeEventListener: function() {
-            document.addEventListener.apply(document, arguments);
+          removeEventListener: function(...args: [
+            string,
+            EventListenerOrEventListenerObject,
+            (boolean | AddEventListenerOptions | undefined)?
+          ]) {
+            document.addEventListener(...args);
           }
         };
         const fixture = createComponent(DraggableInDropZone, [{

src/cdk/overlay/fullscreen-overlay-container.spec.ts

@@ -27,28 +27,28 @@ describe('FullscreenOverlayContainer', () => {
             body: document.body,
             fullscreenElement: document.createElement('div'),
             fullscreenEnabled: true,
-            addEventListener: function(eventName: string, listener: Function) {
+            addEventListener: function(eventName: string, listener: EventListener) {
               if (eventName === 'fullscreenchange') {
                 fullscreenListeners.add(listener);
               } else {
-                document.addEventListener.apply(document, arguments);
+                document.addEventListener(eventName, listener);
               }
             },
-            removeEventListener: function(eventName: string, listener: Function) {
+            removeEventListener: function(eventName: string, listener: EventListener) {
               if (eventName === 'fullscreenchange') {
                 fullscreenListeners.delete(listener);
               } else {
-                document.addEventListener.apply(document, arguments);
+                document.addEventListener(eventName, listener);
               }
             },
-            querySelectorAll: function() {
-              return document.querySelectorAll.apply(document, arguments);
+            querySelectorAll: function(...args: [string]) {
+              return document.querySelectorAll(...args);
             },
-            createElement: function() {
-              return document.createElement.apply(document, arguments);
+            createElement: function(...args: [string, (ElementCreationOptions | undefined)?]) {
+              return document.createElement(...args);
             },
-            getElementsByClassName: function() {
-              return document.getElementsByClassName.apply(document, arguments);
+            getElementsByClassName: function(...args: [string]) {
+              return document.getElementsByClassName(...args);
             }
           };
 

src/cdk/portal/portal.spec.ts

@@ -1,23 +1,24 @@
-import {inject, ComponentFixture, TestBed} from '@angular/core/testing';
+import {CommonModule} from '@angular/common';
 import {
-  NgModule,
+  ApplicationRef,
   Component,
-  ViewChild,
-  ViewChildren,
-  QueryList,
-  ViewContainerRef,
   ComponentFactoryResolver,
-  Optional,
-  Injector,
-  ApplicationRef,
-  TemplateRef,
   ComponentRef,
   ElementRef,
+  Injector,
+  NgModule,
+  Optional,
+  QueryList,
+  TemplateRef,
+  Type,
+  ViewChild,
+  ViewChildren,
+  ViewContainerRef,
 } from '@angular/core';
-import {CommonModule} from '@angular/common';
-import {CdkPortal, CdkPortalOutlet, PortalModule} from './portal-directives';
-import {Portal, ComponentPortal, TemplatePortal, DomPortal} from './portal';
+import {ComponentFixture, inject, TestBed} from '@angular/core/testing';
 import {DomPortalOutlet} from './dom-portal-outlet';
+import {ComponentPortal, DomPortal, Portal, TemplatePortal} from './portal';
+import {CdkPortal, CdkPortalOutlet, PortalModule} from './portal-directives';
 
 
 describe('Portals', () => {
@@ -377,10 +378,9 @@ describe('Portals', () => {
     it('should use the `ComponentFactoryResolver` from the portal, if available', () => {
       const spy = jasmine.createSpy('resolveComponentFactorySpy');
       const portal = new ComponentPortal(PizzaMsg, undefined, undefined, {
-        resolveComponentFactory: (...args: any[]) => {
+        resolveComponentFactory: <T>(...args: [Type<T>]) => {
           spy();
-          return componentFactoryResolver.resolveComponentFactory
-              .apply(componentFactoryResolver, args);
+          return componentFactoryResolver.resolveComponentFactory(...args);
         }
       });
 
@@ -560,10 +560,9 @@ describe('Portals', () => {
     it('should use the `ComponentFactoryResolver` from the portal, if available', () => {
       const spy = jasmine.createSpy('resolveComponentFactorySpy');
       const portal = new ComponentPortal(PizzaMsg, undefined, undefined, {
-        resolveComponentFactory: (...args: any[]) => {
+        resolveComponentFactory: <T>(...args: [Type<T>]) => {
           spy();
-          return componentFactoryResolver.resolveComponentFactory
-              .apply(componentFactoryResolver, args);
+          return componentFactoryResolver.resolveComponentFactory(...args);
         }
       });
 

src/cdk/testing/private/e2e/actions.ts

@@ -14,7 +14,7 @@ import {getElement, FinderResult} from './query';
  */
 export async function pressKeys(...keys: string[]) {
   const actions = browser.actions();
-  await actions.sendKeys.call(actions, keys).perform();
+  await actions.sendKeys(...keys).perform();
 }
 
 /**

src/cdk/testing/testbed/fake-events/event-objects.ts

@@ -14,7 +14,7 @@ import {ModifierKeys} from '@angular/cdk/testing';
  */
 export function createMouseEvent(type: string, x = 0, y = 0, button = 0) {
   const event = document.createEvent('MouseEvent');
-  const originalPreventDefault = event.preventDefault;
+  const originalPreventDefault = event.preventDefault.bind(event);
 
   event.initMouseEvent(type,
     true, /* canBubble */
@@ -39,7 +39,7 @@ export function createMouseEvent(type: string, x = 0, y = 0, button = 0) {
   // IE won't set `defaultPrevented` on synthetic events so we need to do it manually.
   event.preventDefault = function() {
     Object.defineProperty(event, 'defaultPrevented', { get: () => true });
-    return originalPreventDefault.apply(this, arguments);
+    return originalPreventDefault();
   };
 
   return event;

src/cdk/testing/testbed/task-state-zone-interceptor.ts

@@ -91,17 +91,17 @@ export class TaskStateZoneInterceptor {
     // the proxy zone keeps track of the previous task state, so we can just pass
     // this as initial state to the task zone interceptor.
     const interceptor = new TaskStateZoneInterceptor(zoneSpec.lastTaskState);
-    const zoneSpecOnHasTask = zoneSpec.onHasTask;
+    const zoneSpecOnHasTask = zoneSpec.onHasTask.bind(zoneSpec);
 
     // We setup the task state interceptor in the `ProxyZone`. Note that we cannot register
     // the interceptor as a new proxy zone delegate because it would mean that other zone
     // delegates (e.g. `FakeAsyncTestZone` or `AsyncTestZone`) can accidentally overwrite/disable
     // our interceptor. Since we just intend to monitor the task state of the proxy zone, it is
     // sufficient to just patch the proxy zone. This also avoids that we interfere with the task
     // queue scheduling logic.
-    zoneSpec.onHasTask = function() {
-      zoneSpecOnHasTask.apply(zoneSpec, arguments);
-      interceptor.onHasTask.apply(interceptor, arguments);
+    zoneSpec.onHasTask = function(...args: [ZoneDelegate, Zone, Zone, HasTaskState]) {
+      zoneSpecOnHasTask(...args);
+      interceptor.onHasTask(...args);
     };
 
     return zoneSpec[stateObservableSymbol] = interceptor.state;

tsconfig.json

@@ -15,6 +15,7 @@
     "noImplicitAny": true,
     "noImplicitThis": true,
     "skipLibCheck": true,
+    "strictBindCallApply": true,
     "target": "es2015",
     "lib": ["es5", "es2015", "dom"],
     "types": ["jasmine"],