refactor(drag-drop): expose more private apis as protected

Exposes more of the private drag&drop APIs as protected ones, in order to make it easier for people to implement their custom directives based on the CDK ones. Also moves out some of the private helper methods into functions.

Fixes #14113.

Author: crisbeto

src/cdk/drag-drop/drag.ts

@@ -310,7 +310,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
         rootElement.addEventListener('mousedown', this._pointerDown, activeEventListenerOptions);
         rootElement.addEventListener('touchstart', this._pointerDown, passiveEventListenerOptions);
         this._handles.changes.pipe(startWith(null)).subscribe(() =>
-            toggleNativeDragInteractions(rootElement, this.getChildHandles().length > 0));
+            toggleNativeDragInteractions(rootElement, this._getChildHandles().length > 0));
       });
   }
 
@@ -327,7 +327,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
       if (this._isDragging()) {
         // Since we move out the element to the end of the body while it's being
         // dragged, we have to make sure that it's removed if it gets destroyed.
-        this._removeElement(this._rootElement);
+        removeElement(this._rootElement);
       }
     }
 
@@ -346,13 +346,13 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
   }
 
   /** Gets only handles that are not inside descendant `CdkDrag` instances. */
-  private getChildHandles() {
+  protected _getChildHandles() {
     return this._handles.filter(handle => handle._parentDrag === this);
   }
 
   /** Handler for the `mousedown`/`touchstart` events. */
   _pointerDown = (event: MouseEvent | TouchEvent) => {
-    const handles = this.getChildHandles();
+    const handles = this._getChildHandles();
 
     // Delegate the event based on whether it started from a handle or the element itself.
     if (handles.length) {
@@ -376,16 +376,16 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
    * @param referenceElement Element that started the drag sequence.
    * @param event Browser event object that started the sequence.
    */
-  private _initializeDragSequence(referenceElement: HTMLElement, event: MouseEvent | TouchEvent) {
+  protected _initializeDragSequence(referenceElement: HTMLElement, event: MouseEvent | TouchEvent) {
     // Always stop propagation for the event that initializes
     // the dragging sequence, in order to prevent it from potentially
     // starting another sequence for a draggable parent somewhere up the DOM tree.
     event.stopPropagation();
 
     const isDragging = this._isDragging();
-    const isTouchEvent = this._isTouchEvent(event);
-    const isAuxiliaryMouseButton = !isTouchEvent && (event as MouseEvent).button !== 0;
-    const isSyntheticEvent = !isTouchEvent && this._lastTouchEventTime &&
+    const wasTouchEvent = isTouchEvent(event);
+    const isAuxiliaryMouseButton = !wasTouchEvent && (event as MouseEvent).button !== 0;
+    const isSyntheticEvent = !wasTouchEvent && this._lastTouchEventTime &&
         this._lastTouchEventTime + MOUSE_EVENT_IGNORE_TIME > Date.now();
 
     // If the event started from an element with the native HTML drag&drop, it'll interfere
@@ -426,11 +426,11 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
   }
 
   /** Starts the dragging sequence. */
-  private _startDragSequence(event: MouseEvent | TouchEvent) {
+  protected _startDragSequence(event: MouseEvent | TouchEvent) {
     // Emit the event on the item before the one on the container.
     this.started.emit({source: this});
 
-    if (this._isTouchEvent(event)) {
+    if (isTouchEvent(event)) {
       this._lastTouchEventTime = Date.now();
     }
 
@@ -455,7 +455,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
   }
 
   /** Handler that is invoked when the user moves their pointer after they've initiated a drag. */
-  private _pointerMove = (event: MouseEvent | TouchEvent) => {
+  protected _pointerMove = (event: MouseEvent | TouchEvent) => {
     const pointerPosition = this._getConstrainedPointerPosition(event);
 
     if (!this._hasStartedDragging) {
@@ -509,7 +509,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
   }
 
   /** Handler that is invoked when the user lifts their pointer up, after initiating a drag. */
-  private _pointerUp = () => {
+  protected _pointerUp = () => {
     if (!this._isDragging()) {
       return;
     }
@@ -672,7 +672,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
     const elementRect = this._rootElement.getBoundingClientRect();
     const handleElement = referenceElement === this._rootElement ? null : referenceElement;
     const referenceRect = handleElement ? handleElement.getBoundingClientRect() : elementRect;
-    const point = this._isTouchEvent(event) ? event.targetTouches[0] : event;
+    const point = isTouchEvent(event) ? event.targetTouches[0] : event;
     const x = point.pageX - referenceRect.left - this._scrollPosition.left;
     const y = point.pageY - referenceRect.top - this._scrollPosition.top;
 
@@ -729,19 +729,9 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
     });
   }
 
-  /**
-   * Helper to remove an element from the DOM and to do all the necessary null checks.
-   * @param element Element to be removed.
-   */
-  private _removeElement(element: HTMLElement | null) {
-    if (element && element.parentNode) {
-      element.parentNode.removeChild(element);
-    }
-  }
-
   /** Determines the point of the page that was touched by the user. */
   private _getPointerPositionOnPage(event: MouseEvent | TouchEvent): Point {
-    const point = this._isTouchEvent(event) ? event.touches[0] : event;
+    const point = isTouchEvent(event) ? event.touches[0] : event;
 
     return {
       x: point.pageX - this._scrollPosition.left,
@@ -763,15 +753,10 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
     return point;
   }
 
-  /** Determines whether an event is a touch event. */
-  private _isTouchEvent(event: MouseEvent | TouchEvent): event is TouchEvent {
-    return event.type.startsWith('touch');
-  }
-
   /** Destroys the preview element and its ViewRef. */
   private _destroyPreview() {
     if (this._preview) {
-      this._removeElement(this._preview);
+      removeElement(this._preview);
     }
 
     if (this._previewRef) {
@@ -784,7 +769,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
   /** Destroys the placeholder element and its ViewRef. */
   private _destroyPlaceholder() {
     if (this._placeholder) {
-      this._removeElement(this._placeholder);
+      removeElement(this._placeholder);
     }
 
     if (this._placeholderRef) {
@@ -822,7 +807,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
   }
 
   /** Gets the root draggable element, based on the `rootElementSelector`. */
-  private _getRootElement(): HTMLElement {
+  protected _getRootElement(): HTMLElement {
     if (this.rootElementSelector) {
       const selector = this.rootElementSelector;
       let currentElement = this.element.nativeElement.parentElement as HTMLElement | null;
@@ -870,3 +855,18 @@ function deepCloneNode(node: HTMLElement): HTMLElement {
   clone.removeAttribute('id');
   return clone;
 }
+
+/**
+ * Helper to remove an element from the DOM and to do all the necessary null checks.
+ * @param element Element to be removed.
+ */
+function removeElement(element: HTMLElement | null) {
+  if (element && element.parentNode) {
+    element.parentNode.removeChild(element);
+  }
+}
+
+/** Determines whether an event is a touch event. */
+function isTouchEvent(event: MouseEvent | TouchEvent): event is TouchEvent {
+  return event.type.startsWith('touch');
+}

src/cdk/drag-drop/drop-list.ts

@@ -179,14 +179,14 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
   _dragging = false;
 
   /** Cache of the dimensions of all the items and the sibling containers. */
-  private _positionCache: PositionCache = {items: [], siblings: [], self: {} as ClientRect};
+  protected _positionCache: PositionCache = {items: [], siblings: [], self: {} as ClientRect};
 
   /**
    * Draggable items that are currently active inside the container. Includes the items
    * from `_draggables`, as well as any items that have been dragged in, but haven't
    * been dropped yet.
    */
-  private _activeDraggables: CdkDrag[];
+  protected _activeDraggables: CdkDrag[];
 
   /**
    * Keeps track of the item that was last swapped with the dragged item, as
@@ -360,10 +360,10 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
       // elements may be mid-animation which will give us a wrong result.
       if (isHorizontal) {
         elementToOffset.style.transform = `translate3d(${sibling.offset}px, 0, 0)`;
-        this._adjustClientRect(sibling.clientRect, 0, offset);
+        adjustClientRect(sibling.clientRect, 0, offset);
       } else {
         elementToOffset.style.transform = `translate3d(0, ${sibling.offset}px, 0)`;
-        this._adjustClientRect(sibling.clientRect, offset, 0);
+        adjustClientRect(sibling.clientRect, offset, 0);
       }
     });
   }
@@ -435,7 +435,7 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
   }
 
   /** Resets the container to its initial state. */
-  private _reset() {
+  protected _reset() {
     this._dragging = false;
 
     // TODO(crisbeto): may have to wait for the animations to finish.
@@ -447,28 +447,14 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
     this._previousSwap.delta = 0;
   }
 
-  /**
-   * Updates the top/left positions of a `ClientRect`, as well as their bottom/right counterparts.
-   * @param clientRect `ClientRect` that should be updated.
-   * @param top Amount to add to the `top` position.
-   * @param left Amount to add to the `left` position.
-   */
-  private _adjustClientRect(clientRect: ClientRect, top: number, left: number) {
-    clientRect.top += top;
-    clientRect.bottom = clientRect.top + clientRect.height;
-
-    clientRect.left += left;
-    clientRect.right = clientRect.left + clientRect.width;
-  }
-
   /**
    * Gets the index of an item in the drop container, based on the position of the user's pointer.
    * @param item Item that is being sorted.
    * @param pointerX Position of the user's pointer along the X axis.
    * @param pointerY Position of the user's pointer along the Y axis.
    * @param delta Direction in which the user is moving their pointer.
    */
-  private _getItemIndexFromPointerPosition(item: CdkDrag, pointerX: number, pointerY: number,
+  protected _getItemIndexFromPointerPosition(item: CdkDrag, pointerX: number, pointerY: number,
                                            delta?: {x: number, y: number}) {
 
     const isHorizontal = this.orientation === 'horizontal';
@@ -503,7 +489,7 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
    * @param pointerX Coordinates along the X axis.
    * @param pointerY Coordinates along the Y axis.
    */
-  private _isPointerNearDropContainer(pointerX: number, pointerY: number): boolean {
+  protected _isPointerNearDropContainer(pointerX: number, pointerY: number): boolean {
     const {top, right, bottom, left, width, height} = this._positionCache.self;
     const xThreshold = width * DROP_PROXIMITY_THRESHOLD;
     const yThreshold = height * DROP_PROXIMITY_THRESHOLD;
@@ -518,7 +504,7 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
    * @param newPosition Position of the item where the current item should be moved.
    * @param delta Direction in which the user is moving.
    */
-  private _getItemOffsetPx(currentPosition: ClientRect, newPosition: ClientRect, delta: 1 | -1) {
+  protected _getItemOffsetPx(currentPosition: ClientRect, newPosition: ClientRect, delta: 1 | -1) {
     const isHorizontal = this.orientation === 'horizontal';
     let itemOffset = isHorizontal ? newPosition.left - currentPosition.left :
                                     newPosition.top - currentPosition.top;
@@ -538,7 +524,7 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
    * @param siblings All of the items in the list.
    * @param delta Direction in which the user is moving.
    */
-  private _getSiblingOffsetPx(currentIndex: number,
+  protected _getSiblingOffsetPx(currentIndex: number,
                               siblings: ItemPositionCacheEntry[],
                               delta: 1 | -1) {
 
@@ -566,7 +552,7 @@ export class CdkDropList<T = any> implements OnInit, OnDestroy {
   }
 
   /** Gets an array of unique drop lists that the current list is connected to. */
-  private _getConnectedLists(): CdkDropList[] {
+  protected _getConnectedLists(): CdkDropList[] {
     const siblings = coerceArray(this.connectedTo).map(drop => {
       return typeof drop === 'string' ? this._dragDropRegistry.getDropContainer(drop)! : drop;
     });
@@ -613,3 +599,17 @@ function isInsideClientRect(clientRect: ClientRect, x: number, y: number) {
   const {top, bottom, left, right} = clientRect;
   return y >= top && y <= bottom && x >= left && x <= right;
 }
+
+/**
+ * Updates the top/left positions of a `ClientRect`, as well as their bottom/right counterparts.
+ * @param clientRect `ClientRect` that should be updated.
+ * @param top Amount to add to the `top` position.
+ * @param left Amount to add to the `left` position.
+ */
+function adjustClientRect(clientRect: ClientRect, top: number, left: number) {
+  clientRect.top += top;
+  clientRect.bottom = clientRect.top + clientRect.height;
+
+  clientRect.left += left;
+  clientRect.right = clientRect.left + clientRect.width;
+}

src/cdk/drag-drop/public-api.ts

@@ -17,3 +17,4 @@ export * from './drag-preview';
 export * from './drag-placeholder';
 export * from './drag-drop-module';
 export * from './drag-drop-registry';
+export * from './drag-parent';