Skip to content

Commit 4cfc306

Browse files
committed
fixup! fix(cdk-experimental/menu): move shared menu logic to base class
1 parent 8e2790e commit 4cfc306

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

src/cdk-experimental/menu/menu-base.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
Directive,
1414
ElementRef,
1515
Inject,
16-
Input,
1716
OnDestroy,
1817
Optional,
1918
QueryList,

src/material-experimental/menubar/menubar.spec.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {MatMenuBar} from './menubar';
88

99
describe('MatMenuBar', () => {
1010
let fixture: ComponentFixture<SimpleMatMenuBar>;
11-
let matMenubar: MatMenuBar;
1211
let nativeMatMenubar: HTMLElement;
1312

1413
beforeEach(waitForAsync(() => {
@@ -22,7 +21,6 @@ describe('MatMenuBar', () => {
2221
fixture = TestBed.createComponent(SimpleMatMenuBar);
2322
fixture.detectChanges();
2423

25-
matMenubar = fixture.componentInstance.matMenubar;
2624
nativeMatMenubar = fixture.componentInstance.nativeMatMenubar.nativeElement;
2725
});
2826

@@ -39,15 +37,6 @@ describe('MatMenuBar', () => {
3937
expect(nativeMatMenubar.getAttribute('tabindex')).toBe('0');
4038
});
4139

42-
it('should toggle aria-orientation attribute', () => {
43-
expect(nativeMatMenubar.getAttribute('aria-orientation')).toBe('horizontal');
44-
45-
matMenubar.orientation = 'vertical';
46-
fixture.detectChanges();
47-
48-
expect(nativeMatMenubar.getAttribute('aria-orientation')).toBe('vertical');
49-
});
50-
5140
it('should toggle focused items on left/right click', () => {
5241
nativeMatMenubar.focus();
5342

src/material-experimental/menubar/menubar.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,7 @@ import {
2727
encapsulation: ViewEncapsulation.None,
2828
changeDetection: ChangeDetectionStrategy.OnPush,
2929
host: {
30-
'role': 'menubar',
31-
'class': 'cdk-menu-bar mat-menubar',
32-
'tabindex': '0',
33-
'[attr.aria-orientation]': 'orientation',
30+
'[class.mat-menubar]': 'true',
3431
},
3532
providers: [
3633
{provide: CdkMenuGroup, useExisting: MatMenuBar},

0 commit comments

Comments
 (0)