Skip to content

Commit 6329ce7

Browse files
devversionandrewseguin
authored andcommitted
build: re-enable browserstack safari tests
BrowserStack team supposedly fixed the upstream issues. We can re-enable the browserstack tests. It was unclear how long it will take the BS team to fix the server issues, so we temporarily disabled the job before. This reverts commit 555037a.
1 parent d397e28 commit 6329ce7

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

.circleci/config.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -506,10 +506,8 @@ workflows:
506506
filters: *ignore_presubmit_branch_filter
507507
- tests_local_browsers:
508508
filters: *ignore_presubmit_branch_filter
509-
# TODO(devversion): temporarily disabled until BrowserStack fixes an issue
510-
# where Safari browsers cannot be launched due to a missing `device'.
511-
#- tests_browserstack:
512-
# filters: *ignore_presubmit_branch_filter
509+
- tests_browserstack:
510+
filters: *ignore_presubmit_branch_filter
513511
- tests_saucelabs:
514512
filters: *ignore_presubmit_branch_filter
515513
- e2e_tests:

.github/angular-robot.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ merge:
6060
- "ci/circleci: lint"
6161
- "ci/circleci: bazel_build"
6262
- "ci/circleci: tests_local_browsers"
63-
# TODO(devversion): temporarily disabled until Browserstack tests are re-enabled.
64-
# - "ci/circleci: tests_browserstack"
63+
- "ci/circleci: tests_browserstack"
6564
- "ci/circleci: tests_saucelabs"
6665
- "ci/circleci: build_release_packages"
6766

0 commit comments

Comments
 (0)