Skip to content

Commit 7cb77b6

Browse files
devversionVivian Hu
authored and
Vivian Hu
committed
build: fix angular bot not creating size baseline (#14051)
* Currently the Github robot is always pending on `master` because it looks like it couldn't load the artifacts from CircleCI. Based on the source code of the Robot, the artifact paths need to be in a specific path in order to be taken into account.
1 parent 71c205e commit 7cb77b6

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.circleci/config.yml

+7-3
Original file line numberDiff line numberDiff line change
@@ -228,13 +228,17 @@ jobs:
228228
229229
# Publish bundle artifacts which will be used to calculate the size change.
230230
# Note: Make sure that the size plugin from the Angular robot fetches the artifacts
231-
# from this CircleCI job (see .github/angular-robot.yml)
231+
# from this CircleCI job (see .github/angular-robot.yml). Additionally any artifacts need to
232+
# be stored with the following path format: "{projectName}/{context}/{fileName}"
233+
# This format is necessary because otherwise the bot is not able to pick up the
234+
# artifacts from CircleCI. See:
235+
# https://github.com/angular/github-robot/blob/master/functions/src/plugins/size.ts#L392-L394
232236
- store_artifacts:
233237
path: dist/releases/material/bundles/material.umd.js
234-
destination: material.umd.js
238+
destination: /angular_material/material_release_output/material.umd.js
235239
- store_artifacts:
236240
path: /tmp/cdk-umd-artifacts
237-
destination: /
241+
destination: /angular_material/cdk_release_output/
238242

239243
- *save_cache
240244

0 commit comments

Comments
 (0)