Skip to content

Commit 8d54c76

Browse files
devversionmmalerba
authored andcommitted
build: update to node v14
NodeJS v14 is the current LTS version and we should switch as the Angular framework/dev-infra also updates to Node V14. See angular/angular#41544 We remove the engines filed in non-top-level `package.json` files to avoid unnecessary churn. We keep NodeJS v12 working as this is the minimum required version for framework too and diverging could cause productivity issues when switching between projects.
1 parent 78c6d97 commit 8d54c76

File tree

5 files changed

+7
-10
lines changed

5 files changed

+7
-10
lines changed

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@
77
# To validate changes, use an online parser, eg.
88
# http://yaml-online-parser.appspot.com/
99

10-
var_1: &docker_image circleci/node:12.14.1
11-
var_2: &docker-firefox-image circleci/node:12.14.1-browsers
10+
var_1: &docker_image circleci/node:14.16.1
11+
var_2: &docker-firefox-image circleci/node:14.16.1-browsers
1212

1313
# **Note**: When updating the beginning of the cache key, also update the cache key to match
1414
# the new cache key prefix. This allows us to take advantage of CircleCI's fallback caching.
1515
# Read more here: https://circleci.com/docs/2.0/caching/#restoring-cache.
16-
var_3: &cache_key v6-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-{{ checksum "WORKSPACE" }}-{{ checksum "yarn.lock" }}
16+
var_3: &cache_key v7-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-{{ checksum "WORKSPACE" }}-{{ checksum "yarn.lock" }}
1717
# We want to invalidate the cache if the postinstall patches change. In order to apply new
1818
# patches, a clean version of the node modules is needed. Additionally, we invalidate the cache
1919
# if the Bazel version changes. We do this because otherwise the `bazelisk` cache folder will
2020
# contain all previously used versions and ultimately cause the cache restoring to be slower.
21-
var_4: &cache_fallback_key v6-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-
21+
var_4: &cache_fallback_key v7-ng-mat-{{ checksum ".bazelversion" }}-{{ checksum "tools/postinstall/apply-patches.js" }}-
2222

2323
# Settings common to each job
2424
var_5: &job_defaults

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
12.14.1
1+
14.16.1

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "check_bazel_version", "node_repos
2929
check_bazel_version("4.0.0")
3030

3131
node_repositories(
32-
node_version = "12.14.1",
32+
node_version = "14.16.1",
3333
package_json = ["//:package.json"],
3434
)
3535

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"license": "MIT",
1111
"engines": {
12-
"node": "^12.0.0",
12+
"node": ">=12.0.0 <16.0.0",
1313
"yarn": ">= 1.0.0"
1414
},
1515
"scripts": {

scripts/caretaking/firebase-functions/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
"serve": "yarn build && firebase emulators:start --only functions --project test-jperrott",
66
"deploy": "yarn build && firebase deploy --only functions --project test-jperrott"
77
},
8-
"engines": {
9-
"node": "12"
10-
},
118
"main": "lib/index.js",
129
"dependencies": {
1310
"firebase-admin": "^9.0.0",

0 commit comments

Comments
 (0)