Skip to content

Commit 9240dd3

Browse files
committed
comments
1 parent 1684996 commit 9240dd3

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

src/lib/core/data-table/data-table.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,14 +213,15 @@ export class CdkTable<T> implements CollectionViewer {
213213
ngAfterViewInit() {
214214
// Find and construct an iterable differ that can be used to find the diff in an array.
215215
this._dataDiffer = this._differs.find([]).create(this._trackByFn);
216-
217-
this._renderHeaderRow();
218216
this._isViewInitialized = true;
219217
}
220218

221219
ngDoCheck() {
222220
if (this._isViewInitialized && this.dataSource && !this._renderChangeSubscription) {
223-
this._observeRenderChanges();
221+
this._renderHeaderRow();
222+
if (this.dataSource && !this._renderChangeSubscription) {
223+
this._observeRenderChanges();
224+
}
224225
}
225226
}
226227

src/lib/sort/sort-header.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ import {getMdSortHeaderNotContainedWithinMdSortError} from './sort-errors';
3535
'(click)': '_sort.sort(this)',
3636
'[class.mat-sort-header-sorted]': '_isSorted()',
3737
},
38-
encapsulation: ViewEncapsulation.None,
39-
changeDetection: ChangeDetectionStrategy.OnPush,
4038
})
4139
export class MdSortHeader implements MdSortable {
4240
/**

src/lib/sort/sort.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,17 +233,17 @@ class FakeDataSource extends DataSource<any> {
233233
<cdk-table [dataSource]="dataSource" mdSort>
234234
<ng-container cdkColumnDef="column_a">
235235
<cdk-header-cell *cdkHeaderCellDef #sortHeaderA md-sort-header> Column A </cdk-header-cell>
236-
<cdk-cell *cdkCellDef="let row"> {{row.a}}</cdk-cell>
236+
<cdk-cell *cdkCellDef="let row"> {{row.a}} </cdk-cell>
237237
</ng-container>
238238
239239
<ng-container cdkColumnDef="column_b">
240240
<cdk-header-cell *cdkHeaderCellDef #sortHeaderB md-sort-header> Column B </cdk-header-cell>
241-
<cdk-cell *cdkCellDef="let row"> {{row.b}}</cdk-cell>
241+
<cdk-cell *cdkCellDef="let row"> {{row.b}} </cdk-cell>
242242
</ng-container>
243243
244244
<ng-container cdkColumnDef="column_c">
245245
<cdk-header-cell *cdkHeaderCellDef #sortHeaderC md-sort-header> Column C </cdk-header-cell>
246-
<cdk-cell *cdkCellDef="let row"> {{row.c}}</cdk-cell>
246+
<cdk-cell *cdkCellDef="let row"> {{row.c}} </cdk-cell>
247247
</ng-container>
248248
249249
<cdk-header-row *cdkHeaderRowDef="columnsToRender"></cdk-header-row>

0 commit comments

Comments
 (0)