Skip to content

Commit 997589d

Browse files
committed
fix(material-experimental/mdc-slide-toggle): remove aria-required rather than setting to false (#24105)
Both are equally valid to mark the control as not required, but setting it to false generates a bunch of false-positive lint errors in google3 (cherry picked from commit 2cc0640)
1 parent ca10cc4 commit 997589d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/material-experimental/mdc-slide-toggle/slide-toggle.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
[attr.aria-label]="ariaLabel"
1414
[attr.aria-labelledby]="_getAriaLabelledBy()"
1515
[attr.aria-describedby]="ariaDescribedby"
16-
[attr.aria-required]="required"
16+
[attr.aria-required]="required || null"
1717
(click)="_handleClick($event)"
1818
#switch>
1919
<div class="mdc-switch__track"></div>

src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ describe('MDC-based MatSlideToggle without forms', () => {
274274
testComponent.isRequired = false;
275275
fixture.detectChanges();
276276

277-
expect(buttonElement.getAttribute('aria-required')).toBe('false');
277+
expect(buttonElement.getAttribute('aria-required')).toBe(null);
278278
});
279279

280280
it('should focus on underlying element when focus() is called', fakeAsync(() => {

0 commit comments

Comments
 (0)