Skip to content

Commit aa17fbd

Browse files
authored
Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)
* Revert "fix(drag-drop): error on touch end (#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)" This reverts commit c99c512.
1 parent 53cecbb commit aa17fbd

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

src/lib/autocomplete/autocomplete-trigger.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,6 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, OnDestroy {
493493
switchMap(() => {
494494
this._resetActiveItem();
495495
this.autocomplete._setVisibility();
496-
this._changeDetectorRef.detectChanges();
497496

498497
if (this.panelOpen) {
499498
this._overlayRef!.updatePosition();

src/lib/autocomplete/autocomplete.spec.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1644,22 +1644,6 @@ describe('MatAutocomplete', () => {
16441644
.toContain('mat-active', 'Expected first option to be highlighted.');
16451645
}));
16461646

1647-
it('should be able to preselect the first option when the floating label is disabled',
1648-
fakeAsync(() => {
1649-
fixture.componentInstance.floatLabel = 'never';
1650-
fixture.componentInstance.trigger.autocomplete.autoActiveFirstOption = true;
1651-
fixture.detectChanges();
1652-
1653-
fixture.componentInstance.trigger.openPanel();
1654-
fixture.detectChanges();
1655-
zone.simulateZoneExit();
1656-
// Note: should not have a detectChanges call here
1657-
// in order for the test to fail when it's supposed to.
1658-
1659-
expect(overlayContainerElement.querySelectorAll('mat-option')[0].classList)
1660-
.toContain('mat-active', 'Expected first option to be highlighted.');
1661-
}));
1662-
16631647
it('should be able to configure preselecting the first option globally', fakeAsync(() => {
16641648
overlayContainer.ngOnDestroy();
16651649
fixture.destroy();

0 commit comments

Comments
 (0)