Skip to content

Commit c262622

Browse files
committed
test that beforeClose emits before container is destroyed
1 parent 39e38da commit c262622

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/lib/dialog/dialog.spec.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,20 @@ describe('MdDialog', () => {
141141
}));
142142

143143
it('should close a dialog and get back a result before it is closed', async(() => {
144-
let dialogRef = dialog.open(PizzaMsg, { viewContainerRef: testViewContainerRef });
145-
let beforeCloseCallback = jasmine.createSpy('beforeClose callback');
144+
const dialogRef = dialog.open(PizzaMsg, { viewContainerRef: testViewContainerRef });
145+
146+
// beforeClose should emit before dialog container is destroyed
147+
const beforeCloseHandler = jasmine.createSpy('beforeClose callback').and.callFake(() => {
148+
expect(overlayContainerElement.querySelector('md-dialog-container'))
149+
.not.toBeNull('dialog container exists when beforeClose is called');
150+
});
146151

147-
dialogRef.beforeClose().subscribe(beforeCloseCallback);
152+
dialogRef.beforeClose().subscribe(beforeCloseHandler);
148153
dialogRef.close('Bulbasaurus');
149154
viewContainerFixture.detectChanges();
150155

151156
viewContainerFixture.whenStable().then(() => {
152-
expect(beforeCloseCallback).toHaveBeenCalledWith('Bulbasaurus');
157+
expect(beforeCloseHandler).toHaveBeenCalledWith('Bulbasaurus');
153158
expect(overlayContainerElement.querySelector('md-dialog-container')).toBeNull();
154159
});
155160
}));

0 commit comments

Comments
 (0)