Skip to content

Commit cb98270

Browse files
jelbournmmalerba
authored andcommitted
fix: add camelCase selectors for cdk directives (#4054)
Some of the cdk directives used the incorrect selector style. This change adds the proper camelCase selectors. The dash-case selectors will be considered deprecated in the next release and then removed in a subsequent release.
1 parent 16bba72 commit cb98270

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/lib/core/overlay/overlay-directives.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ let defaultPositionList = [
4545
* ConnectedPositionStrategy.
4646
*/
4747
@Directive({
48-
selector: '[cdk-overlay-origin], [overlay-origin]',
48+
selector: '[cdk-overlay-origin], [overlay-origin], [cdkOverlayOrigin]',
4949
exportAs: 'cdkOverlayOrigin',
5050
})
5151
export class OverlayOrigin {
@@ -58,7 +58,7 @@ export class OverlayOrigin {
5858
* Directive to facilitate declarative creation of an Overlay using a ConnectedPositionStrategy.
5959
*/
6060
@Directive({
61-
selector: '[cdk-connected-overlay], [connected-overlay]',
61+
selector: '[cdk-connected-overlay], [connected-overlay], [cdkConnectedOverlay]',
6262
exportAs: 'cdkConnectedOverlay'
6363
})
6464
export class ConnectedOverlayDirective implements OnDestroy {

src/lib/core/overlay/scroll/scrollable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import 'rxjs/add/observable/fromEvent';
1111
* can be listened to through the service.
1212
*/
1313
@Directive({
14-
selector: '[cdk-scrollable]'
14+
selector: '[cdk-scrollable], [cdkScrollable]'
1515
})
1616
export class Scrollable implements OnInit, OnDestroy {
1717
private _elementScrolled: Subject<Event> = new Subject();

src/lib/core/portal/portal-directives.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {Portal, TemplatePortal, ComponentPortal, BasePortalHost} from './portal'
2222
* </ng-template>
2323
*/
2424
@Directive({
25-
selector: '[cdk-portal], [portal]',
25+
selector: '[cdk-portal], [cdkPortal], [portal]',
2626
exportAs: 'cdkPortal',
2727
})
2828
export class TemplatePortalDirective extends TemplatePortal {

0 commit comments

Comments
 (0)