Skip to content

Commit d20ca92

Browse files
devversionzarend
authored andcommitted
build: update version of rules_sass to remove workaround (#23518)
Updates the version of `rules_sass` to the latest version so that we can remove our `@bazel/worker` workaround now that we have landed the Bazel worker v4.x compatibility fix upstream. (cherry picked from commit 27984dc)
1 parent 69f442a commit d20ca92

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

WORKSPACE

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ http_archive(
1515
# Add sass rules
1616
http_archive(
1717
name = "io_bazel_rules_sass",
18-
sha256 = "60fa023fe694848acf769d816ad9fee970a27a37489aaf5443a7ccffaac805e9",
19-
strip_prefix = "rules_sass-1.38.2",
18+
sha256 = "334b2ad87c13109486a8bfdc8d80d90e4ce6a4528bc6fb090b021ec87c2c3080",
19+
strip_prefix = "rules_sass-1.39.0",
2020
urls = [
21-
"https://github.com/bazelbuild/rules_sass/archive/1.38.2.zip",
21+
"https://github.com/bazelbuild/rules_sass/archive/1.39.0.zip",
2222
],
2323
)
2424

@@ -76,17 +76,10 @@ load("@io_bazel_rules_sass//:package.bzl", "rules_sass_dependencies")
7676

7777
rules_sass_dependencies()
7878

79-
# TODO(devversion): remove workaround once `rules_sass` supports v4 of the Bazel NodeJS rules,
80-
# or when https://github.com/bazelbuild/rules_nodejs/issues/2807 is solved. For now, we just
81-
# replicate the original `sass_repositories` call and manually add the `--ignore-scripts`
82-
# Yarn argument to not run the postinstall version check of `@bazel/worker`
83-
yarn_install(
84-
name = "build_bazel_rules_sass_deps",
85-
args = ["--ignore-scripts"],
86-
package_json = "@io_bazel_rules_sass//sass:package.json",
87-
symlink_node_modules = False,
88-
yarn_lock = "@io_bazel_rules_sass//sass:yarn.lock",
89-
)
79+
# Setup the Sass rule repositories.
80+
load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories")
81+
82+
sass_repositories()
9083

9184
# Setup repositories for browsers provided by the shared dev-infra package.
9285
load(

0 commit comments

Comments
 (0)