Skip to content

Commit d3357b8

Browse files
josephperrottmmalerba
authored andcommitted
build: update to [email protected] (#17929)
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
1 parent 498b884 commit d3357b8

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.bazelrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ test --test_output=errors
4040
# Configures script to do version stamping.
4141
# See https://docs.bazel.build/versions/master/user-manual.html#flag--workspace_status_command
4242
build:release --workspace_status_command="node ./tools/bazel-stamp-vars.js"
43+
build:release --stamp
4344

4445
################################
4546
# View Engine / Ivy toggle #

WORKSPACE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
88
# Add NodeJS rules
99
http_archive(
1010
name = "build_bazel_rules_nodejs",
11-
sha256 = "8dc1466f8563f3aa4ac7ab7aa3c96651eb7764108219f40b2d1c918e1a81c601",
12-
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.41.0/rules_nodejs-0.41.0.tar.gz"],
11+
sha256 = "a54b2511d6dae42c1f7cdaeb08144ee2808193a088004fc3b464a04583d5aa2e",
12+
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.42.3/rules_nodejs-0.42.3.tar.gz"],
1313
)
1414

1515
# Add sass rules

0 commit comments

Comments
 (0)