Skip to content

Commit d5c2dcd

Browse files
committed
add jsdoc, export TextOptions interface
1 parent a724e5c commit d5c2dcd

File tree

7 files changed

+17
-14
lines changed

7 files changed

+17
-14
lines changed

src/cdk/testing/protractor/protractor-element.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
ElementDimensions,
1111
ModifierKeys,
1212
TestElement,
13-
TestKey
13+
TestKey, TextOptions
1414
} from '@angular/cdk/testing';
1515
import {browser, ElementFinder, Key} from 'protractor';
1616
import {getTextWithExcludedElements} from '@angular/cdk/testing/text-filtering';
@@ -135,7 +135,7 @@ export class ProtractorElement implements TestElement {
135135
return this.element.sendKeys(...keys);
136136
}
137137

138-
async text(options?: {exclude?: string}): Promise<string> {
138+
async text(options?: TextOptions): Promise<string> {
139139
if (options?.exclude) {
140140
return browser.executeScript(getTextWithExcludedElements, this.element, options.exclude);
141141
}

src/cdk/testing/test-element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export interface TestElement {
133133
isFocused(): Promise<boolean>;
134134
}
135135

136-
interface TextOptions {
136+
export interface TextOptions {
137137
/** Optional selector for elements to exclude. */
138138
exclude?: string
139139
}

src/cdk/testing/testbed/unit-test-element.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
ElementDimensions,
1212
ModifierKeys,
1313
TestElement,
14-
TestKey
14+
TestKey, TextOptions
1515
} from '@angular/cdk/testing';
1616
import {
1717
clearElement,
@@ -132,7 +132,7 @@ export class UnitTestElement implements TestElement {
132132
await this._stabilize();
133133
}
134134

135-
async text(options?: {exclude?: string}): Promise<string> {
135+
async text(options?:TextOptions): Promise<string> {
136136
await this._stabilize();
137137
if (options?.exclude) {
138138
return getTextWithExcludedElements(this.element, options.exclude);

src/cdk/testing/text-filtering.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
/**
2+
* Gets text of element excluding certain selectors within the element.
3+
* @param element Element to get text from,
4+
* @param excludeSelector Selector identifying which elements to exclude,
5+
*/
16
export function getTextWithExcludedElements(element: Element, excludeSelector: string) {
27
const clone = element.cloneNode(true) as Element;
38
const exclusions = clone.querySelectorAll(excludeSelector);

tools/public_api_guard/cdk/testing.d.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,7 @@ export interface TestElement {
131131
sendKeys(...keys: (string | TestKey)[]): Promise<void>;
132132
sendKeys(modifiers: ModifierKeys, ...keys: (string | TestKey)[]): Promise<void>;
133133
setInputValue?(value: string): Promise<void>;
134-
text(options?: {
135-
exclude?: string;
136-
}): Promise<string>;
134+
text(options?: TextOptions): Promise<string>;
137135
}
138136

139137
export declare enum TestKey {
@@ -168,3 +166,7 @@ export declare enum TestKey {
168166
F12 = 28,
169167
META = 29
170168
}
169+
170+
export interface TextOptions {
171+
exclude?: string;
172+
}

tools/public_api_guard/cdk/testing/protractor.d.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ export declare class ProtractorElement implements TestElement {
1717
sendKeys(...keys: (string | TestKey)[]): Promise<void>;
1818
sendKeys(modifiers: ModifierKeys, ...keys: (string | TestKey)[]): Promise<void>;
1919
setInputValue(value: string): Promise<void>;
20-
text(options?: {
21-
exclude?: string;
22-
}): Promise<string>;
20+
text(options?: TextOptions): Promise<string>;
2321
}
2422

2523
export declare class ProtractorHarnessEnvironment extends HarnessEnvironment<ElementFinder> {

tools/public_api_guard/cdk/testing/testbed.d.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,5 @@ export declare class UnitTestElement implements TestElement {
3434
sendKeys(...keys: (string | TestKey)[]): Promise<void>;
3535
sendKeys(modifiers: ModifierKeys, ...keys: (string | TestKey)[]): Promise<void>;
3636
setInputValue(value: string): Promise<void>;
37-
text(options?: {
38-
exclude?: string;
39-
}): Promise<string>;
37+
text(options?: TextOptions): Promise<string>;
4038
}

0 commit comments

Comments
 (0)