Skip to content

Commit dc859fe

Browse files
devversionjelbourn
authored andcommitted
build: remove example-module from gitignore
In order to work around an Angular Bazel bug where genfiles aren't properly picked up in the `ng_module` metadata bundler, we need to check-in the example module into the source-file and use the example-module as a real source instead of generating it dynamically through a genfile. This allows us to temporarily fix the examples package until the bug (angular/angular#30259) is fixed.
1 parent 5bf0487 commit dc859fe

File tree

5 files changed

+60
-8
lines changed

5 files changed

+60
-8
lines changed

.gitignore

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
/bazel-out
88

99
# Example module file will be auto-generated.
10-
/src/material-examples/example-module.ts
10+
# TODO(devversion): re-add the example-module once angular#30259 is fixed.
11+
# /src/material-examples/example-module.ts
1112

1213
# dependencies
1314
node_modules
@@ -40,4 +41,4 @@ yarn-error.log
4041
testem.log
4142
/.chrome
4243
/.git
43-
/.firebase
44+
/.firebase

src/material-examples/BUILD.bazel

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ load("//tools/package-docs-content:index.bzl", "package_docs_content")
77

88
ng_module(
99
name = "examples",
10-
srcs = glob(["**/*.ts"]) + [":example-module"],
10+
# TODO(paul): re-add the example-module genfile once angular/angular#30259 is resolved.
11+
srcs = glob(["**/*.ts"]),
1112
module_name = "@angular/material-examples",
1213
assets = glob(["**/*.html", "**/*.css"]),
1314
deps = [

0 commit comments

Comments
 (0)