Skip to content

Commit f0ebd2a

Browse files
authored
refactor(material/datepicker): unit test with not the first of the month (#24401)
This change only affects the unit tests and doesn't not affect application code. It's a small improvement to the unit tests in the multi-year view to use Jan 3 instead of Jan 1. This can catch more bugs because we could catch that we're setting a date to the first of the month when we're not supposed to.
1 parent fd745d1 commit f0ebd2a

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

src/material/datepicker/multi-year-view.spec.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ describe('MatMultiYearView', () => {
116116
) as HTMLElement;
117117
expect(calendarBodyEl).not.toBeNull();
118118
dir.value = 'ltr';
119-
fixture.componentInstance.date = new Date(2017, JAN, 1);
119+
fixture.componentInstance.date = new Date(2017, JAN, 3);
120120
dispatchFakeEvent(calendarBodyEl, 'focus');
121121
fixture.detectChanges();
122122
});
@@ -125,96 +125,96 @@ describe('MatMultiYearView', () => {
125125
dispatchKeyboardEvent(calendarBodyEl, 'keydown', LEFT_ARROW);
126126
fixture.detectChanges();
127127

128-
expect(calendarInstance.date).toEqual(new Date(2016, JAN, 1));
128+
expect(calendarInstance.date).toEqual(new Date(2016, JAN, 3));
129129

130130
dispatchKeyboardEvent(calendarBodyEl, 'keydown', LEFT_ARROW);
131131
fixture.detectChanges();
132132

133-
expect(calendarInstance.date).toEqual(new Date(2015, JAN, 1));
133+
expect(calendarInstance.date).toEqual(new Date(2015, JAN, 3));
134134
});
135135

136136
it('should increment year on right arrow press', () => {
137137
dispatchKeyboardEvent(calendarBodyEl, 'keydown', RIGHT_ARROW);
138138
fixture.detectChanges();
139139

140-
expect(calendarInstance.date).toEqual(new Date(2018, JAN, 1));
140+
expect(calendarInstance.date).toEqual(new Date(2018, JAN, 3));
141141

142142
dispatchKeyboardEvent(calendarBodyEl, 'keydown', RIGHT_ARROW);
143143
fixture.detectChanges();
144144

145-
expect(calendarInstance.date).toEqual(new Date(2019, JAN, 1));
145+
expect(calendarInstance.date).toEqual(new Date(2019, JAN, 3));
146146
});
147147

148148
it('should go up a row on up arrow press', () => {
149149
dispatchKeyboardEvent(calendarBodyEl, 'keydown', UP_ARROW);
150150
fixture.detectChanges();
151151

152-
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerRow, JAN, 1));
152+
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerRow, JAN, 3));
153153

154154
dispatchKeyboardEvent(calendarBodyEl, 'keydown', UP_ARROW);
155155
fixture.detectChanges();
156156

157-
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerRow * 2, JAN, 1));
157+
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerRow * 2, JAN, 3));
158158
});
159159

160160
it('should go down a row on down arrow press', () => {
161161
dispatchKeyboardEvent(calendarBodyEl, 'keydown', DOWN_ARROW);
162162
fixture.detectChanges();
163163

164-
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerRow, JAN, 1));
164+
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerRow, JAN, 3));
165165

166166
dispatchKeyboardEvent(calendarBodyEl, 'keydown', DOWN_ARROW);
167167
fixture.detectChanges();
168168

169-
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerRow * 2, JAN, 1));
169+
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerRow * 2, JAN, 3));
170170
});
171171

172172
it('should go to first year in current range on home press', () => {
173173
dispatchKeyboardEvent(calendarBodyEl, 'keydown', HOME);
174174
fixture.detectChanges();
175175

176-
expect(calendarInstance.date).toEqual(new Date(2016, JAN, 1));
176+
expect(calendarInstance.date).toEqual(new Date(2016, JAN, 3));
177177

178178
dispatchKeyboardEvent(calendarBodyEl, 'keydown', HOME);
179179
fixture.detectChanges();
180180

181-
expect(calendarInstance.date).toEqual(new Date(2016, JAN, 1));
181+
expect(calendarInstance.date).toEqual(new Date(2016, JAN, 3));
182182
});
183183

184184
it('should go to last year in current range on end press', () => {
185185
dispatchKeyboardEvent(calendarBodyEl, 'keydown', END);
186186
fixture.detectChanges();
187187

188-
expect(calendarInstance.date).toEqual(new Date(2039, JAN, 1));
188+
expect(calendarInstance.date).toEqual(new Date(2039, JAN, 3));
189189

190190
dispatchKeyboardEvent(calendarBodyEl, 'keydown', END);
191191
fixture.detectChanges();
192192

193-
expect(calendarInstance.date).toEqual(new Date(2039, JAN, 1));
193+
expect(calendarInstance.date).toEqual(new Date(2039, JAN, 3));
194194
});
195195

196196
it('should go to same index in previous year range page up press', () => {
197197
dispatchKeyboardEvent(calendarBodyEl, 'keydown', PAGE_UP);
198198
fixture.detectChanges();
199199

200-
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerPage, JAN, 1));
200+
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerPage, JAN, 3));
201201

202202
dispatchKeyboardEvent(calendarBodyEl, 'keydown', PAGE_UP);
203203
fixture.detectChanges();
204204

205-
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerPage * 2, JAN, 1));
205+
expect(calendarInstance.date).toEqual(new Date(2017 - yearsPerPage * 2, JAN, 3));
206206
});
207207

208208
it('should go to same index in next year range on page down press', () => {
209209
dispatchKeyboardEvent(calendarBodyEl, 'keydown', PAGE_DOWN);
210210
fixture.detectChanges();
211211

212-
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerPage, JAN, 1));
212+
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerPage, JAN, 3));
213213

214214
dispatchKeyboardEvent(calendarBodyEl, 'keydown', PAGE_DOWN);
215215
fixture.detectChanges();
216216

217-
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerPage * 2, JAN, 1));
217+
expect(calendarInstance.date).toEqual(new Date(2017 + yearsPerPage * 2, JAN, 3));
218218
});
219219

220220
it('should go to the year that is focused', () => {

0 commit comments

Comments
 (0)