Skip to content

Commit fdebd41

Browse files
committed
build: fix invalid required angular version
* Right now the `package.json` of the release packages accepts every Angular 6.0.0 beta as a working dependency. This is not really correct since we depend on the `preserveWhitespaces` change from `beta.6` and also depend on the new `Injectable` / `provider` syntax from `beta.4`. We either need to require a version `>= beta.6` or just go to the `6.0.0` stable release. * Makes it easier to change the required angular version (right now it's easy to forget about the property in the build config)
1 parent 2ffdae6 commit fdebd41

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

build-config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const buildVersion = packageJson.version;
1313
* Required Angular version for all Angular Material packages. This version will be used
1414
* as the peer dependency version for Angular in all release packages.
1515
*/
16-
const angularVersion = '>=6.0.0-beta.0 <7.0.0';
16+
const angularVersion = packageJson.requiredAngularVersion;
1717

1818
/** License that will be placed inside of all created bundles. */
1919
const buildLicense = `/**

package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
"type": "git",
88
"url": "https://github.com/angular/material2.git"
99
},
10+
"license": "MIT",
11+
"engines": {
12+
"node": ">= 5.4.1"
13+
},
1014
"scripts": {
1115
"postinstall": "ngc -p angular.tsconfig.json",
1216
"build": "gulp :publish:build-releases",
@@ -21,10 +25,7 @@
2125
"api": "gulp api-docs"
2226
},
2327
"version": "6.4.2",
24-
"license": "MIT",
25-
"engines": {
26-
"node": ">= 5.4.1"
27-
},
28+
"requiredAngularVersion": ">=6.0.0 <7.0.0",
2829
"dependencies": {
2930
"@angular/animations": "6.0.0",
3031
"@angular/common": "6.0.0",

0 commit comments

Comments
 (0)