Skip to content

fix(material/card): Adds original padding for a card footer #28833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lsamboretrorabbit
Copy link
Contributor

The mat-progress-bar overflows when placed in the mat-card-footer. Content should not extend beyond the borders of the card

Fixes #28785

The mat-progress-bar overflows when placed in the mat-card-footer.
Content should not extend beyond the borders of the card

Fixes angular#28785
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is the right way to fix it. I think that we either:

  1. Just remove the example with the progress bar. I don't think it's in the spec anymore.
  2. Add overflow: hidden.

The mat-progress-bar overflows when placed in the mat-card-footer.
Content should not extend beyond the borders of the card

Removed the display: flex property as it is not required for the footer component

Fixes angular#28785
@lsamboretrorabbit
Copy link
Contributor Author

@crisbeto I have made updates to the SCSS file

  1. Removed the display flex property as it not required for the footer component
  2. Provided a snapshot of how the progress bar looks within the footer

image

@josephperrott josephperrott requested a review from a team as a code owner December 18, 2024 17:40
@josephperrott josephperrott requested review from andrewseguin and removed request for a team December 18, 2024 17:40
@mmalerba mmalerba removed their request for review February 19, 2025 22:20
@mazeneko
Copy link

mazeneko commented Apr 9, 2025

Any updates on this issue?
Just checking in since it’s been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(material/card): The mat-progress-bar overflows when placed in the mat-card-footer
3 participants