drop the module = module; emit by tsickle

This was a workaround for JSCompiler warning that module is an unused variable,
but we fixed this more appropriately by suppressing that warning.

PiperOrigin-RevId: 316150037

Author: evmar

src/googmodule.ts

@@ -613,13 +613,6 @@ export function commonJsToGoogmoduleTransformer(
                                          'module', /* type */ undefined, moduleVarInitializer)]));
       headerStmts.push(modAssign);
 
-      if (!host.es5Mode) {
-        // The module=module assignment suppresses an unused variable warning which may trigger
-        // depending on the project's compilation flags.
-        headerStmts.push(ts.createStatement(
-            ts.createAssignment(ts.createIdentifier('module'), ts.createIdentifier('module'))));
-      }
-
       // Add `goog.require('tslib');` if not JS transpilation, and it hasn't already been required.
       // Rationale:
       // TS gets compiled to Development mode (ES5) and Closure mode (~ES6)

test/googmodule_test.ts

@@ -77,7 +77,6 @@ console.log('hello');
     // NB: no line break added below.
     expectCommonJs('a.ts', `console.log('hello');`, false).toBe(`goog.module('a');
 var module = module || { id: 'a.ts' };
-module = module;
 goog.require('tslib');
 console.log('hello');
 `);
@@ -124,7 +123,6 @@ console.log(mod_1.x);
         /* es5 mode= */ false)
         .toBe(`goog.module('a');
 var module = module || { id: 'a.ts' };
-module = module;
 goog.require('tslib');
 const mod_1 = goog.require('req.mod');
 console.log(mod_1.x);
@@ -389,7 +387,6 @@ console.log(goog_foo_bar_1, relative_1.es6RelativeRequire, relative_2.es6NonRela
     expectCommonJs('a.ts', `export {}; console.log('hello'); exports = 1;`, false)
         .toBe(`goog.module('a');
 var module = module || { id: 'a.ts' };
-module = module;
 goog.require('tslib');
 console.log('hello');
 exports = 1;

test_files/abstract/abstract.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.abstract.abstract');
 var module = module || { id: 'test_files/abstract/abstract.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @abstract

test_files/anon_class/anon_class.js

@@ -8,7 +8,6 @@
 // produce {?}.
 goog.module('test_files.anon_class.anon_class');
 var module = module || { id: 'test_files/anon_class/anon_class.ts' };
-module = module;
 goog.require('tslib');
 /** @type {?} */
 const anonClassInstance = new class {

test_files/arrow_fn.untyped/arrow_fn.untyped.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.arrow_fn.untyped.arrow_fn.untyped');
 var module = module || { id: 'test_files/arrow_fn.untyped/arrow_fn.untyped.ts' };
-module = module;
 goog.require('tslib');
 /** @type {?} */
 var fn3 = (/**

test_files/arrow_fn/arrow_fn.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.arrow_fn.arrow_fn');
 var module = module || { id: 'test_files/arrow_fn/arrow_fn.ts' };
-module = module;
 goog.require('tslib');
 /** @type {function(number): number} */
 var fn3 = (/**

test_files/async_functions/async_functions.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.async_functions.async_functions');
 var module = module || { id: 'test_files/async_functions/async_functions.ts' };
-module = module;
 const tslib_1 = goog.require('tslib');
 /**
  * Exercises various forms of async functions.  When TypeScript downlevels these functions, it

test_files/augment/user.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.augment.user');
 var module = module || { id: 'test_files/augment/user.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_angular_1 = goog.requireType("test_files.augment.angular.index");
 const ng = goog.require('test_files.augment.angular.index');

test_files/automatic_semicolon_insertion/asi.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.automatic_semicolon_insertion.asi');
 var module = module || { id: 'test_files/automatic_semicolon_insertion/asi.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @return {function(number): number}

test_files/basic.untyped/basic.untyped.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.basic.untyped.basic.untyped');
 var module = module || { id: 'test_files/basic.untyped/basic.untyped.ts' };
-module = module;
 goog.require('tslib');
 // This test is just a random collection of typed code, to
 // ensure the output is all with {?} annotations.

test_files/blacklisted_ambient_external_module/user.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.blacklisted_ambient_external_module.user');
 var module = module || { id: 'test_files/blacklisted_ambient_external_module/user.ts' };
-module = module;
 goog.require('tslib');
 class User {
     constructor() { this.field = null; }

test_files/cast_extends/cast_extends.js

@@ -10,7 +10,6 @@
  */
 goog.module('test_files.cast_extends.cast_extends');
 var module = module || { id: 'test_files/cast_extends/cast_extends.ts' };
-module = module;
 goog.require('tslib');
 class Someclass {
 }

test_files/class.untyped/class.js

@@ -6,7 +6,6 @@
  */
 goog.module('test_files.class.untyped.class');
 var module = module || { id: 'test_files/class.untyped/class.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @record

test_files/class/class.js

@@ -18,7 +18,6 @@
 // other options.
 goog.module('test_files.class.class');
 var module = module || { id: 'test_files/class/class.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @record

test_files/clutz.no_externs/import_default.js

@@ -8,7 +8,6 @@
  */
 goog.module('test_files.clutz.no_externs.import_default');
 var module = module || { id: 'test_files/clutz.no_externs/import_default.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_goog_default_export_1 = goog.requireType("default_export");
 /** @type {(null|!tsickle_goog_default_export_1)} */

test_files/clutz.no_externs/strip_clutz_type.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.clutz.no_externs.strip_clutz_type');
 var module = module || { id: 'test_files/clutz.no_externs/strip_clutz_type.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_space_1 = goog.requireType("some.name.space");
 const tsickle_other_2 = goog.requireType("some.other");

test_files/clutz_type_value.no_externs/user.js

@@ -8,7 +8,6 @@
  */
 goog.module('test_files.clutz_type_value.no_externs.user');
 var module = module || { id: 'test_files/clutz_type_value.no_externs/user.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_goog_type_value_1 = goog.requireType("type_value");
 // We expect IFace to show up in the @implements tag.

test_files/coerce/coerce.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.coerce.coerce');
 var module = module || { id: 'test_files/coerce/coerce.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @param {string} arg

test_files/comments/comments.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.comments.comments');
 var module = module || { id: 'test_files/comments/comments.ts' };
-module = module;
 goog.require('tslib');
 class Comments {
 }

test_files/conditional_rest_tuple_type/conditional_rest_tuple_type.js

@@ -8,7 +8,6 @@
  */
 goog.module('test_files.conditional_rest_tuple_type.conditional_rest_tuple_type');
 var module = module || { id: 'test_files/conditional_rest_tuple_type/conditional_rest_tuple_type.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @template T

test_files/conditional_type/conditional_type.js

@@ -6,7 +6,6 @@
  */
 goog.module('test_files.conditional_type.conditional_type');
 var module = module || { id: 'test_files/conditional_type/conditional_type.ts' };
-module = module;
 goog.require('tslib');
 /** @typedef {?} */
 exports.Filter;

test_files/ctors/ctors.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.ctors.ctors');
 var module = module || { id: 'test_files/ctors/ctors.ts' };
-module = module;
 goog.require('tslib');
 /** @type {function(new:Document)} */
 let x = Document;

test_files/debugger/user.js

@@ -9,7 +9,6 @@
 // See https://github.com/Microsoft/TypeScript/issues/29459
 goog.module('test_files.debugger.user');
 var module = module || { id: 'test_files/debugger/user.ts' };
-module = module;
 goog.require('tslib');
 /** @type {(null|!_debugger.Foo)} */
 const x = null;

test_files/declare/declare_nondts.js

@@ -5,5 +5,4 @@
  */
 goog.module('test_files.declare.declare_nondts');
 var module = module || { id: 'test_files/declare/declare_nondts.ts' };
-module = module;
 goog.require('tslib');

test_files/declare/user.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.declare.user');
 var module = module || { id: 'test_files/declare/user.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_declare_module_1 = goog.requireType("test_files.declare.declare_module");
 const declare_module_1 = goog.require('test_files.declare.declare_module');

test_files/declare_class_ns/declare_class_ns.js

@@ -5,5 +5,4 @@
  */
 goog.module('test_files.declare_class_ns.declare_class_ns');
 var module = module || { id: 'test_files/declare_class_ns/declare_class_ns.ts' };
-module = module;
 goog.require('tslib');

test_files/declare_class_overloads/declare_class_overloads.js

@@ -5,5 +5,4 @@
  */
 goog.module('test_files.declare_class_overloads.declare_class_overloads');
 var module = module || { id: 'test_files/declare_class_overloads/declare_class_overloads.ts' };
-module = module;
 goog.require('tslib');

test_files/declare_export.untyped/declare_export.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.declare_export.untyped.declare_export');
 var module = module || { id: 'test_files/declare_export.untyped/declare_export.ts' };
-module = module;
 goog.require('tslib');
 ;
 ;

test_files/declare_export/declare_export.js

@@ -15,7 +15,6 @@
 // Closure builtin Error type.
 goog.module('test_files.declare_export.declare_export');
 var module = module || { id: 'test_files/declare_export/declare_export.ts' };
-module = module;
 goog.require('tslib');
 /** @type {!test_files$declare_export$declare_export.ExportDeclaredIf} */
 let user1;

test_files/declare_export_dts/user.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.declare_export_dts.user');
 var module = module || { id: 'test_files/declare_export_dts/user.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_declare_export_dts_1 = goog.requireType("test_files.declare_export_dts.declare_export_dts");
 /** @type {!tsickle_declare_export_dts_1.InterfaceExportedInDts} */

test_files/declare_import/export_default.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.declare_import.export_default');
 var module = module || { id: 'test_files/declare_import/export_default.ts' };
-module = module;
 goog.require('tslib');
 // tslint:disable-next-line:no-default-export
 class ExportDefaultClass {

test_files/declare_import/exporter.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.declare_import.exporter');
 var module = module || { id: 'test_files/declare_import/exporter.ts' };
-module = module;
 goog.require('tslib');
 class ExportedClass {
 }

test_files/decorator/decorator.js

@@ -6,9 +6,8 @@
  */
 goog.module('test_files.decorator.decorator');
 var module = module || { id: 'test_files/decorator/decorator.ts' };
-module = module;
-const __tsickle_googReflect = goog.require("goog.reflect");
 const tslib_1 = goog.require('tslib');
+const __tsickle_googReflect = goog.require("goog.reflect");
 const tsickle_default_export_1 = goog.requireType("test_files.decorator.default_export");
 const tsickle_external_2 = goog.requireType("test_files.decorator.external");
 const tsickle_external2_3 = goog.requireType("test_files.decorator.external2");

test_files/decorator/default_export.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.decorator.default_export');
 var module = module || { id: 'test_files/decorator/default_export.ts' };
-module = module;
 goog.require('tslib');
 // tslint:disable-next-line:no-default-export
 class DefaultExport {

test_files/decorator/external.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.decorator.external');
 var module = module || { id: 'test_files/decorator/external.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_external2_1 = goog.requireType("test_files.decorator.external2");
 const external2_1 = goog.require('test_files.decorator.external2');

test_files/decorator/external2.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.decorator.external2');
 var module = module || { id: 'test_files/decorator/external2.ts' };
-module = module;
 goog.require('tslib');
 class OtherClass {
 }

test_files/decorator/only_types.js

@@ -8,7 +8,6 @@
  */
 goog.module('test_files.decorator.only_types');
 var module = module || { id: 'test_files/decorator/only_types.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @record

test_files/decorator_nested_scope/decorator_nested_scope.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.decorator_nested_scope.decorator_nested_scope');
 var module = module || { id: 'test_files/decorator_nested_scope/decorator_nested_scope.ts' };
-module = module;
 goog.require('tslib');
 class SomeService {
 }

test_files/default/default.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.default.default');
 var module = module || { id: 'test_files/default/default.ts' };
-module = module;
 goog.require('tslib');
 /**
  * @param {number} x

test_files/doc_params/doc_params.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.doc_params.doc_params');
 var module = module || { id: 'test_files/doc_params/doc_params.ts' };
-module = module;
 goog.require('tslib');
 class Foo {
     /**

test_files/docs_on_ctor_param_properties/docs_on_ctor_param_properties.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.docs_on_ctor_param_properties.docs_on_ctor_param_properties');
 var module = module || { id: 'test_files/docs_on_ctor_param_properties/docs_on_ctor_param_properties.ts' };
-module = module;
 goog.require('tslib');
 class Clazz {
     /**

test_files/enum.untyped/enum.untyped.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.enum.untyped.enum.untyped');
 var module = module || { id: 'test_files/enum.untyped/enum.untyped.ts' };
-module = module;
 goog.require('tslib');
 /** @enum {number} */
 const EnumUntypedTest1 = {

test_files/enum/enum.js

@@ -7,7 +7,6 @@
 // Line with a missing semicolon should not break the following enum.
 goog.module('test_files.enum.enum');
 var module = module || { id: 'test_files/enum/enum.ts' };
-module = module;
 goog.require('tslib');
 /** @type {!Array<?>} */
 const EnumTestMissingSemi = [];

test_files/enum/enum_user.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.enum.enum_user');
 var module = module || { id: 'test_files/enum/enum_user.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_enum_1 = goog.requireType("test_files.enum.enum");
 /**

test_files/enum_ref_import/enum_ref_import.js

@@ -15,7 +15,6 @@
  */
 goog.module('test_files.enum_ref_import.enum_ref_import');
 var module = module || { id: 'test_files/enum_ref_import/enum_ref_import.ts' };
-module = module;
 goog.require('tslib');
 const tsickle_exporter_1 = goog.requireType("test_files.enum_ref_import.exporter");
 /** @enum {string} */

test_files/enum_ref_import/exporter.js

@@ -5,7 +5,6 @@
  */
 goog.module('test_files.enum_ref_import.exporter');
 var module = module || { id: 'test_files/enum_ref_import/exporter.ts' };
-module = module;
 goog.require('tslib');
 /** @enum {string} */
 const Enum = {

test_files/enum_value_literal_type/enum_value_literal_type.js

@@ -9,7 +9,6 @@
 // exporting an enum's value, not that.
 goog.module('test_files.enum_value_literal_type.enum_value_literal_type');
 var module = module || { id: 'test_files/enum_value_literal_type/enum_value_literal_type.ts' };
-module = module;
 goog.require('tslib');
 /** @enum {number} */
 const ExportedEnum = {