Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Commit effe466

Browse files
rrdelaneycopybara-github
authored andcommitted
Update tsickle release instructions to use wombat dressing room
PiperOrigin-RevId: 319251373
1 parent afc41a2 commit effe466

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

.clang-format

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Language: JavaScript
2+
BasedOnStyle: Google
3+
ColumnLimit: 100

README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ any of the below commands to make sure you are using the right version.
140140
- `ibazel test test:unit_test` executes the unit tests in watch mode (use `bazel test test:unit_test` for a single run),
141141
- `bazel test test:e2e_test` executes the e2e tests,
142142
- `bazel test test:golden_test` executes the golden tests,
143-
- `yarn test` runs unit tests and e2e tests.
143+
- `node check_format.js` checks the source code formatting using
144+
`clang-format`,
145+
- `yarn test` runs unit tests, e2e tests and checks the source code formatting.
144146

145147
### Debugging
146148

@@ -210,5 +212,8 @@ $ git push origin v0.32.0 # but use correct version
210212
Once the versioned tag is pushed to Github the release (as found on
211213
https://github.com/angular/tsickle/releases) will be implicitly created.
212214

213-
Run `bazel run :npm_package.publish` from the master branch
214-
(you must be logged into the `angular` shared npm account).
215+
From the master branch run:
216+
217+
```
218+
bazel run :npm_package.publish -- --registry https://wombat-dressing-room.appspot.com
219+
```

test_files/cast_extends/cast_extends.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
// test_files/cast_extends/cast_extends.ts(16,1): warning TS0: unhandled type flags: Intersection
2-
// test_files/cast_extends/cast_extends.ts(22,10): warning TS0: unhandled type flags: Intersection
1+
// test_files/cast_extends/cast_extends.ts(16,1): warning TS0: unhandled type flags: IncludesNonWideningType
2+
// test_files/cast_extends/cast_extends.ts(22,10): warning TS0: unhandled type flags: IncludesNonWideningType
33
/**
44
*
55
* @fileoverview Reproduces an issue where tsickle would emit a cast for the "extends" claus, and

test_files/mixin/dtsdiagnostics.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
test_files/mixin/mixin.d.ts(1,1): warning TS0: unhandled type flags: Intersection
1+
test_files/mixin/mixin.d.ts(1,1): warning TS0: unhandled type flags: IncludesNonWideningType
22
test_files/mixin/mixin.d.ts(12,31): warning TS0: dropped extends of non-symbol supertype: MyMixin(HTMLElement)

0 commit comments

Comments
 (0)