Address ruff S, EXE skips (#3889)

Author: ssbarnea

pyproject.toml

@@ -161,17 +161,15 @@ ignore = [
   "FBT", # Boolean positional value in function call
   # Temporary disabled until we fix them:
   "A",
-  "ANN",
+  "ANN", # Annotations
   "ARG",
   "B",
   "BLE001",
   "C901",
   "D",
   "E741",
   "EM",
-  "EXE",
   "INP",
-  "ISC",
   "N",
   "PGH",
   "PLR",

src/molecule/command/init/scenario.py

@@ -125,7 +125,7 @@ def _role_exists(ctx, param, value: str):  # pragma: no cover
 
     role_directory = os.path.join(os.pardir, value)
     if not os.path.exists(role_directory):
-        msg = f"The role '{value}' not found. " "Please choose the proper role name."
+        msg = f"The role '{value}' not found. Please choose the proper role name."
         util.sysexit_with_message(msg)
     return value
 

src/molecule/command/test.py

@@ -75,7 +75,7 @@ def execute(self, action_args=None):
     "--destroy",
     type=click.Choice(["always", "never"]),
     default="always",
-    help=("The destroy strategy used at the conclusion of a " "Molecule run (always)."),
+    help=("The destroy strategy used at the conclusion of a Molecule run (always)."),
 )
 @click.option(
     "--parallel/--no-parallel",

src/molecule/provisioner/ansible.py

@@ -947,7 +947,7 @@ def _verify_inventory(self):
         :return: None
         """
         if not self.inventory:
-            msg = "Instances missing from the 'platform' " + "section of molecule.yml."
+            msg = "Instances missing from the 'platform' section of molecule.yml."
             util.sysexit_with_message(msg)
 
     def _get_config_template(self):

src/molecule/shell.py

@@ -106,7 +106,7 @@ def print_version(ctx, param, value):
     "--env-file",
     "-e",
     default=ENV_FILE,
-    help=("The file to read variables from when rendering molecule.yml. " "(.env.yml)"),
+    help=("The file to read variables from when rendering molecule.yml. (.env.yml)"),
 )
 @click.option(
     "--version",

src/molecule/test/scenarios/verifier/molecule/testinfra-pre-commit/tests/test_testinfra_pre_commit.py

@@ -1,4 +1,3 @@
-#!/usr/bin/python
 """Testinfra tests."""
 
 

src/molecule/test/unit/command/test_base.py

@@ -244,7 +244,7 @@ def test_runtime_paths(config_instance, _patched_sysexit):
     )
 
     assert runtime_collections_path.startswith(
-        f"{cache_dir}/collections:" f"{home}/.ansible/collections",
+        f"{cache_dir}/collections:{home}/.ansible/collections",
     )
 
     assert provisioner_roles_path.startswith(f"{cache_dir}/roles")

src/molecule/test/unit/dependency/ansible_galaxy/test_roles.py

@@ -29,7 +29,7 @@
 @pytest.fixture()
 def _patched_ansible_galaxy_has_requirements_file(mocker):
     m = mocker.patch(
-        "molecule.dependency.ansible_galaxy.roles." + "Roles._has_requirements_file",
+        "molecule.dependency.ansible_galaxy.roles.Roles._has_requirements_file",
     )
     m.return_value = True