Nits

Author: pitrou

cpp/src/arrow/compute/kernels/aggregate.cc

@@ -54,7 +54,9 @@ Status AggregateUnaryKernel::Call(FunctionContext* ctx, const Datum& input, Datu
     return Status::Invalid("AggregateKernel expects Array or ChunkedArray datum");
   }
   auto state = ManagedAggregateState::Make(aggregate_function_, ctx->memory_pool());
-  if (!state) return Status::OutOfMemory("AggregateState allocation failed");
+  if (!state) {
+    return Status::OutOfMemory("AggregateState allocation failed");
+  }
 
   if (input.is_array()) {
     auto array = input.make_array();
@@ -64,7 +66,9 @@ Status AggregateUnaryKernel::Call(FunctionContext* ctx, const Datum& input, Datu
     for (int i = 0; i < chunked_array->num_chunks(); i++) {
       auto tmp_state =
           ManagedAggregateState::Make(aggregate_function_, ctx->memory_pool());
-      if (!tmp_state) return Status::OutOfMemory("AggregateState allocation failed");
+      if (!tmp_state) {
+        return Status::OutOfMemory("AggregateState allocation failed");
+      }
       RETURN_NOT_OK(aggregate_function_->Consume(*chunked_array->chunk(i),
                                                  tmp_state->mutable_data()));
       RETURN_NOT_OK(

cpp/src/arrow/compute/kernels/aggregate_test.cc

@@ -140,16 +140,16 @@ TYPED_TEST(TestNumericSumKernel, SimpleSum) {
   ValidateSum<TypeParam>(&this->ctx_, "[0, 1, 2, 3, 4, 5]",
                          Datum(std::make_shared<ScalarType>(static_cast<T>(5 * 6 / 2))));
 
-  std::vector<std::string> json{"[0, 1, 2, 3, 4, 5]"};
-  ValidateSum<TypeParam>(&this->ctx_, json,
+  std::vector<std::string> chunks = {"[0, 1, 2, 3, 4, 5]"};
+  ValidateSum<TypeParam>(&this->ctx_, chunks,
                          Datum(std::make_shared<ScalarType>(static_cast<T>(5 * 6 / 2))));
 
-  json = {"[0, 1, 2]", "[3, 4, 5]"};
-  ValidateSum<TypeParam>(&this->ctx_, json,
+  chunks = {"[0, 1, 2]", "[3, 4, 5]"};
+  ValidateSum<TypeParam>(&this->ctx_, chunks,
                          Datum(std::make_shared<ScalarType>(static_cast<T>(5 * 6 / 2))));
 
-  json = {"[0, 1, 2]", "[]", "[3, 4, 5]"};
-  ValidateSum<TypeParam>(&this->ctx_, json,
+  chunks = {"[0, 1, 2]", "[]", "[3, 4, 5]"};
+  ValidateSum<TypeParam>(&this->ctx_, chunks,
                          Datum(std::make_shared<ScalarType>(static_cast<T>(5 * 6 / 2))));
 
   const T expected_result = static_cast<T>(14);