refactor: don't use init fn

nikpivkin · nikpivkin · commit 9d2240aa82a4 · 2024-06-17T19:53:21.000+07:00
diff --git a/pkg/iac/rego/scanner.go b/pkg/iac/rego/scanner.go
@@ -30,14 +30,15 @@ var checkTypesWithSubtype = map[types.Source]struct{}{
 	types.SourceKubernetes: {},
 }
 
-var supportedProviders map[string]struct{}
+var supportedProviders = makeSupportedProviders()
 
-func init() {
-	supportedProviders = make(map[string]struct{})
+func makeSupportedProviders() map[string]struct{} {
+	m := make(map[string]struct{})
 	for _, p := range providers.AllProviders() {
-		supportedProviders[string(p)] = struct{}{}
+		m[string(p)] = struct{}{}
 	}
-	supportedProviders["kind"] = struct{}{} // kubernetes
+	m["kind"] = struct{}{} // kubernetes
+	return m
 }
 
 var _ options.ConfigurableScanner = (*Scanner)(nil)

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,15 @@ var checkTypesWithSubtype = map[types.Source]struct{}{`
`30`	`30`	`types.SourceKubernetes: {},`
`31`	`31`	`}`
`32`	`32`
`33`		`-var supportedProviders map[string]struct{}`
	`33`	`+var supportedProviders = makeSupportedProviders()`
`34`	`34`
`35`		`-func init() {`
`36`		`- supportedProviders = make(map[string]struct{})`
	`35`	`+func makeSupportedProviders() map[string]struct{} {`
	`36`	`+ m := make(map[string]struct{})`
`37`	`37`	`for _, p := range providers.AllProviders() {`
`38`		`- supportedProviders[string(p)] = struct{}{}`
	`38`	`+ m[string(p)] = struct{}{}`
`39`	`39`	`}`
`40`		`- supportedProviders["kind"] = struct{}{} // kubernetes`
	`40`	`+ m["kind"] = struct{}{} // kubernetes`
	`41`	`+ return m`
`41`	`42`	`}`
`42`	`43`
`43`	`44`	`var _ options.ConfigurableScanner = (*Scanner)(nil)`