fix(cli): always output fatal errors to stderr (#6827)

knqyf263 · web-flow · commit c2b9132a7e93 · 2024-06-02T11:41:55.000Z
Signed-off-by: knqyf263 &lt;knqyf263@gmail.com&gt;
diff --git a/pkg/log/logger.go b/pkg/log/logger.go
@@ -67,7 +67,8 @@ func Errorf(format string, args ...any) { slog.Default().Error(fmt.Sprintf(forma
 
 // Fatal for logging fatal errors
 func Fatal(msg string, args ...any) {
-	slog.Default().Log(context.Background(), LevelFatal, msg, args...)
+	// Fatal errors should be logged to stderr even if the logger is disabled.
+	New(NewHandler(os.Stderr, &Options{})).Log(context.Background(), LevelFatal, msg, args...)
 	os.Exit(1)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,8 @@ func Errorf(format string, args ...any) { slog.Default().Error(fmt.Sprintf(forma`
`67`	`67`
`68`	`68`	`// Fatal for logging fatal errors`
`69`	`69`	`func Fatal(msg string, args ...any) {`
`70`		`- slog.Default().Log(context.Background(), LevelFatal, msg, args...)`
	`70`	`+ // Fatal errors should be logged to stderr even if the logger is disabled.`
	`71`	`+ New(NewHandler(os.Stderr, &Options{})).Log(context.Background(), LevelFatal, msg, args...)`
`71`	`72`	`os.Exit(1)`
`72`	`73`	`}`
`73`	`74`