fix(misconf): do not skip loading documents from subdirectories #8526
Conversation
Signed-off-by: nikpivkin <[email protected]>
| // The virtual file system uses a slash ('/') as a path separator, | ||
| // but OPA uses the filepath package, which is OS-dependent. | ||
| // Therefore, we need to collect all the paths ourselves and pass them to OPA. | ||
| for _, root := range dataPaths { |
There was a problem hiding this comment.
This fixes the loading of data files on windows
| } | ||
| return nil | ||
| }); err != nil { | ||
| log.Error("Failed to collect data file paths", log.String("root", root), log.Err(err)) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Which test are you referring to? The link just points to scanner_test.go file.
There was a problem hiding this comment.
There was a problem hiding this comment.
The current behavior ignores the error (if any) that gets returned by fs.WalkDir. The test is simply simulating a case where an invalid filesystem is passed in and therefore fs.WalkDir will return an error.
But should we return an error here if we are unable to override the filesystem for data? This would only happen if the passed in srcFS isn't nil. In other cases we simply ignore it.
There was a problem hiding this comment.
srcFS is only used to load data if no file system with data is passed through options. Therefore an error can occur in both cases. But I think I understood that the test is just checking that the data was not loaded.
Signed-off-by: nikpivkin <[email protected]>
Description
Checklist