More manual tests for Equal.

Author: lamai93

pkg/apis/deployment/v1alpha/conditions.go

@@ -23,6 +23,7 @@
 package v1alpha
 
 import (
+	"github.com/arangodb/kube-arangodb/pkg/util"
 	"k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -77,13 +78,18 @@ type Condition struct {
 type ConditionList []Condition
 
 // Equal checks for equality
-func (cl ConditionList) Equal(other ConditionList) bool {
-	if len(cl) != len(other) {
+func (list ConditionList) Equal(other ConditionList) bool {
+	if len(list) != len(other) {
 		return false
 	}
 
-	for i := 0; i < len(cl); i++ {
-		if !cl[i].Equal(other[i]) {
+	for i := 0; i < len(list); i++ {
+		c, found := other.Get(list[i].Type)
+		if !found {
+			return false
+		}
+
+		if !list[i].Equal(c) {
 			return false
 		}
 	}
@@ -95,8 +101,8 @@ func (cl ConditionList) Equal(other ConditionList) bool {
 func (c Condition) Equal(other Condition) bool {
 	return c.Type == other.Type &&
 		c.Status == other.Status &&
-		c.LastUpdateTime.Time.Sub(other.LastUpdateTime.Time).Seconds() < 2 &&
-		c.LastTransitionTime.Time.Sub(other.LastTransitionTime.Time).Seconds() < 2 &&
+		util.TimeCompareEqual(c.LastUpdateTime, other.LastUpdateTime) &&
+		util.TimeCompareEqual(c.LastTransitionTime, other.LastTransitionTime) &&
 		c.Reason == other.Reason &&
 		c.Message == other.Message
 }

pkg/apis/deployment/v1alpha/deployment_spec.go

@@ -23,6 +23,8 @@
 package v1alpha
 
 import (
+	"reflect"
+
 	"github.com/arangodb/kube-arangodb/pkg/util"
 	"github.com/pkg/errors"
 	"k8s.io/api/core/v1"
@@ -69,6 +71,11 @@ type DeploymentSpec struct {
 	Chaos ChaosSpec `json:"chaos"`
 }
 
+// Equal compares two DeploymentSpec
+func (s *DeploymentSpec) Equal(other *DeploymentSpec) bool {
+	return reflect.DeepEqual(s, other)
+}
+
 // GetMode returns the value of mode.
 func (s DeploymentSpec) GetMode() DeploymentMode {
 	return ModeOrDefault(s.Mode)

pkg/apis/deployment/v1alpha/deployment_status.go

@@ -22,10 +22,6 @@
 
 package v1alpha
 
-import (
-	"reflect"
-)
-
 // DeploymentStatus contains the status part of a Cluster resource.
 type DeploymentStatus struct {
 	// Phase holds the current lifetime phase of the deployment
@@ -68,11 +64,11 @@ func (ds *DeploymentStatus) Equal(other DeploymentStatus) bool {
 		ds.Reason == other.Reason &&
 		ds.ServiceName == other.ServiceName &&
 		ds.SyncServiceName == other.SyncServiceName &&
-		reflect.DeepEqual(ds.Images, other.Images) &&
-		reflect.DeepEqual(ds.CurrentImage, other.CurrentImage) &&
+		ds.Images.Equal(other.Images) &&
+		ds.CurrentImage.Equal(other.CurrentImage) &&
 		ds.Members.Equal(other.Members) &&
 		ds.Conditions.Equal(other.Conditions) &&
-		reflect.DeepEqual(ds.Plan, other.Plan) &&
-		reflect.DeepEqual(ds.AcceptedSpec, other.AcceptedSpec) &&
-		reflect.DeepEqual(ds.SecretHashes, other.SecretHashes)
+		ds.Plan.Equal(other.Plan) &&
+		ds.AcceptedSpec.Equal(other.AcceptedSpec) &&
+		ds.SecretHashes.Equal(other.SecretHashes)
 }

pkg/apis/deployment/v1alpha/image_info.go

@@ -71,3 +71,38 @@ func (l *ImageInfoList) AddOrUpdate(info ImageInfo) {
 	// No existing entry found, add it
 	*l = append(*l, info)
 }
+
+// Equal compares to ImageInfo
+func (i *ImageInfo) Equal(other *ImageInfo) bool {
+	if i == other {
+		return true
+	} else if i == nil {
+		return false
+	}
+
+	return i.ArangoDBVersion == other.ArangoDBVersion &&
+		i.Enterprise == other.Enterprise &&
+		i.Image == other.Image &&
+		i.ImageID == other.ImageID
+}
+
+// Equal compares to ImageInfoList
+func (l ImageInfoList) Equal(other ImageInfoList) bool {
+	if len(l) != len(other) {
+		return false
+	}
+
+	for i := 0; i < len(l); i++ {
+		ii, found := l.GetByImageID(l[i].ImageID)
+
+		if !found {
+			return false
+		}
+
+		if !l[i].Equal(&ii) {
+			return false
+		}
+	}
+
+	return true
+}

pkg/apis/deployment/v1alpha/member_status.go

@@ -25,6 +25,7 @@ package v1alpha
 import (
 	"time"
 
+	"github.com/arangodb/kube-arangodb/pkg/util"
 	"k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -58,7 +59,7 @@ type MemberStatus struct {
 func (s MemberStatus) Equal(other MemberStatus) bool {
 	return s.ID == other.ID &&
 		s.Phase == other.Phase &&
-		s.CreatedAt.Time.Sub(other.CreatedAt.Time).Seconds() < 2 &&
+		util.TimeCompareEqual(s.CreatedAt, other.CreatedAt) &&
 		s.PersistentVolumeClaimName == other.PersistentVolumeClaimName &&
 		s.PodName == other.PodName &&
 		s.Conditions.Equal(other.Conditions) &&

pkg/apis/deployment/v1alpha/member_status_list.go

@@ -33,13 +33,18 @@ import (
 type MemberStatusList []MemberStatus
 
 // Equal checks for equality
-func (msl MemberStatusList) Equal(other MemberStatusList) bool {
-	if len(msl) != len(other) {
+func (l MemberStatusList) Equal(other MemberStatusList) bool {
+	if len(l) != len(other) {
 		return false
 	}
 
-	for i := 0; i < len(msl); i++ {
-		if !msl[i].Equal(other[i]) {
+	for i := 0; i < len(l); i++ {
+		o, found := l.ElementByID(l[i].ID)
+		if !found {
+			return false
+		}
+
+		if !l[i].Equal(o) {
 			return false
 		}
 	}

pkg/apis/deployment/v1alpha/plan.go

@@ -23,6 +23,7 @@
 package v1alpha
 
 import (
+	"github.com/arangodb/kube-arangodb/pkg/util"
 	"github.com/dchest/uniuri"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -79,6 +80,18 @@ type Action struct {
 	Image string `json:"image,omitempty"`
 }
 
+// Equal compares two Actions
+func (a Action) Equal(other Action) bool {
+	return a.ID == other.ID &&
+		a.Type == other.Type &&
+		a.MemberID == other.MemberID &&
+		a.Group == other.Group &&
+		util.TimeCompareEqual(a.CreationTime, other.CreationTime) &&
+		util.TimeCompareEqualPointer(a.StartTime, other.StartTime) &&
+		a.Reason == other.Reason &&
+		a.Image == other.Image
+}
+
 // NewAction instantiates a new Action.
 func NewAction(actionType ActionType, group ServerGroup, memberID string, reason ...string) Action {
 	a := Action{
@@ -105,3 +118,19 @@ func (a Action) SetImage(image string) Action {
 // Only 1 action is in progress at a time. The operator will wait for that
 // action to be completely and then remove the action.
 type Plan []Action
+
+// Equal compares two Plan
+func (p Plan) Equal(other Plan) bool {
+	// For plan the order is relevant!
+	if len(p) != len(other) {
+		return false
+	}
+
+	for i := 0; i < len(p); i++ {
+		if !p[i].Equal(other[i]) {
+			return false
+		}
+	}
+
+	return true
+}

pkg/apis/deployment/v1alpha/secret_hashes.go

@@ -35,3 +35,17 @@ type SecretHashes struct {
 	// SyncTLSCA contains the hash of the sync.tls.caSecretName secret
 	SyncTLSCA string `json:"sync-tls-ca,omitempty"`
 }
+
+// Equal compares two SecretHashes
+func (sh *SecretHashes) Equal(other *SecretHashes) bool {
+	if sh == other {
+		return true
+	} else if sh == nil {
+		return false
+	}
+
+	return sh.AuthJWT == other.AuthJWT &&
+		sh.RocksDBEncryptionKey == other.RocksDBEncryptionKey &&
+		sh.TLSCA == other.TLSCA &&
+		sh.SyncTLSCA == other.SyncTLSCA
+}

pkg/deployment/deployment.go

@@ -24,7 +24,6 @@ package deployment
 
 import (
 	"fmt"
-	"reflect"
 	"sync"
 	"sync/atomic"
 	"time"
@@ -390,7 +389,7 @@ func (d *Deployment) updateCRStatus(force ...bool) error {
 // On success, d.apiObject is updated.
 func (d *Deployment) updateCRSpec(newSpec api.DeploymentSpec) error {
 
-	if reflect.DeepEqual(d.apiObject.Spec, newSpec) {
+	if d.apiObject.Spec.Equal(&newSpec) {
 		// Nothing to update
 		return nil
 	}

pkg/util/times.go

@@ -0,0 +1,45 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Lars Maier
+//
+
+package util
+
+import (
+	"math"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// TimeCompareEqual compares two times, allowing an error of 1s
+func TimeCompareEqual(a, b metav1.Time) bool {
+	return math.Abs(a.Time.Sub(b.Time).Seconds()) <= 1
+}
+
+// TimeCompareEqualPointer compares two times, allowing an error of 1s
+func TimeCompareEqualPointer(a, b *metav1.Time) bool {
+	if a == b {
+		return true
+	} else if a == nil {
+		return false
+	}
+
+	return TimeCompareEqual(*a, *b)
+}