Merge pull request #94 from arangodb/prepull-enterprise-image

Added helper to prepull arangodb (enterprise) image. This allows the normal tests to have decent timeouts while prevent a timeout caused by a long during image pull.

Author: ewoutp

manifests/templates/test/rbac.yaml

@@ -9,6 +9,9 @@ rules:
 - apiGroups: [""]
   resources: ["nodes"]
   verbs: ["list"]
+- apiGroups: ["apps"]
+  resources: ["daemonsets"]
+  verbs: ["*"]
 
 ---
 

tests/prepull_image_util.go

@@ -0,0 +1,100 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Ewout Prangsma
+//
+
+package tests
+
+import (
+	"crypto/sha1"
+	"fmt"
+	"strings"
+	"time"
+
+	"github.com/dchest/uniuri"
+	appsv1 "k8s.io/api/apps/v1"
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/kubernetes"
+
+	"github.com/arangodb/kube-arangodb/pkg/util/retry"
+)
+
+// prepullImage runs a daemonset that pulls a given ArangoDB image on all nodes.
+func prepullArangoImage(cli kubernetes.Interface, image, namespace string) error {
+	name := "prepuller-" + strings.ToLower(uniuri.NewLen(4))
+	dsLabels := map[string]string{
+		"app":        "prepuller",
+		"image-hash": fmt.Sprintf("%0x", sha1.Sum([]byte(image)))[:10],
+	}
+	ds := &appsv1.DaemonSet{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:   name,
+			Labels: dsLabels,
+		},
+		Spec: appsv1.DaemonSetSpec{
+			Selector: &metav1.LabelSelector{
+				MatchLabels: dsLabels,
+			},
+			Template: corev1.PodTemplateSpec{
+				ObjectMeta: metav1.ObjectMeta{
+					Labels: dsLabels,
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{
+						corev1.Container{
+							Name:  "arango",
+							Image: image,
+							Env: []corev1.EnvVar{
+								corev1.EnvVar{
+									Name:  "ARANGO_NO_AUTH",
+									Value: "1",
+								},
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+	// Create DS
+	if _, err := cli.AppsV1().DaemonSets(namespace).Create(ds); err != nil {
+		return maskAny(err)
+	}
+	// Cleanup on exit
+	defer func() {
+		cli.AppsV1().DaemonSets(namespace).Delete(name, &metav1.DeleteOptions{})
+	}()
+	// Now wait for it to be ready
+	op := func() error {
+		current, err := cli.AppsV1().DaemonSets(namespace).Get(name, metav1.GetOptions{})
+		if err != nil {
+			return maskAny(err)
+		}
+		if current.Status.DesiredNumberScheduled > current.Status.NumberReady {
+			return maskAny(fmt.Errorf("Expected %d pods to be ready, got %d", current.Status.DesiredNumberScheduled, current.Status.NumberReady))
+		}
+		return nil
+	}
+	if err := retry.Retry(op, time.Hour); err != nil {
+		return maskAny(err)
+	}
+	return nil
+}

tests/rocksdb_encryption_test.go

@@ -6,6 +6,8 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
+
 	"github.com/dchest/uniuri"
 
 	api "github.com/arangodb/kube-arangodb/pkg/apis/deployment/v1alpha"
@@ -23,6 +25,9 @@ func TestRocksDBEncryptionSingle(t *testing.T) {
 	kubecli := mustNewKubeClient(t)
 	ns := getNamespace(t)
 
+	// Prepull enterprise images
+	assert.NoError(t, prepullArangoImage(kubecli, image, ns))
+
 	// Prepare deployment config
 	depl := newDeployment("test-rocksdb-enc-sng-" + uniuri.NewLen(4))
 	depl.Spec.Mode = api.NewMode(api.DeploymentModeSingle)