Skip to content

Commit 92e8561

Browse files
authored
Fix regression re report-size-deltas after updating actions/upload-artifact. (#51)
For more information see https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event .
1 parent 1978660 commit 92e8561

File tree

3 files changed

+33
-27
lines changed

3 files changed

+33
-27
lines changed

.github/workflows/compile-examples.yml

+32-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ on:
1919
repository_dispatch:
2020

2121
jobs:
22-
build:
22+
compile:
2323
name: ${{ matrix.board.fqbn }}
2424
runs-on: ubuntu-latest
2525

@@ -34,36 +34,47 @@ jobs:
3434
- fqbn: arduino:samd:arduino_zero_edbg
3535
platforms: |
3636
- name: arduino:samd
37+
artifact-name-suffix: arduino-samd-arduino_zero_edbg
3738
- fqbn: arduino:samd:mkr1000
3839
platforms: |
3940
- name: arduino:samd
41+
artifact-name-suffix: arduino-samd-mkr1000
4042
- fqbn: arduino:samd:mkrzero
4143
platforms: |
4244
- name: arduino:samd
45+
artifact-name-suffix: arduino-samd-mkrzero
4346
- fqbn: arduino:samd:mkrwifi1010
4447
platforms: |
4548
- name: arduino:samd
49+
artifact-name-suffix: arduino-samd-mkrwifi1010
4650
- fqbn: arduino:samd:mkrfox1200
4751
platforms: |
4852
- name: arduino:samd
53+
artifact-name-suffix: arduino-samd-mkrfox1200
4954
- fqbn: arduino:samd:mkrwan1300
5055
platforms: |
5156
- name: arduino:samd
57+
artifact-name-suffix: arduino-samd-mkrwan1300
5258
- fqbn: arduino:samd:mkrwan1310
5359
platforms: |
5460
- name: arduino:samd
61+
artifact-name-suffix: arduino-samd-mkrwan1310
5562
- fqbn: arduino:samd:mkrgsm1400
5663
platforms: |
5764
- name: arduino:samd
65+
artifact-name-suffix: arduino-samd-mkrgsm1400
5866
- fqbn: arduino:samd:mkrnb1500
5967
platforms: |
6068
- name: arduino:samd
69+
artifact-name-suffix: arduino-samd-mkrnb1500
6170
- fqbn: arduino:samd:mkrvidor4000
6271
platforms: |
6372
- name: arduino:samd
73+
artifact-name-suffix: arduino-samd-mkrvidor4000
6474
- fqbn: arduino:samd:nano_33_iot
6575
platforms: |
6676
- name: arduino:samd
77+
artifact-name-suffix: arduino-samd-nano_33_iot
6778

6879
steps:
6980
- name: Checkout repository
@@ -84,9 +95,27 @@ jobs:
8495
enable-deltas-report: true
8596
sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }}
8697

87-
- name: Save sketches report as workflow artifact
98+
- name: Upload sketches report to workflow artifact
8899
uses: actions/upload-artifact@v4
89100
with:
90101
if-no-files-found: error
91102
path: ${{ env.SKETCHES_REPORTS_PATH }}
92-
name: ${{ env.SKETCHES_REPORTS_PATH }}
103+
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
104+
105+
# When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
106+
report:
107+
needs: compile # Wait for the compile job to finish to get the data for the report
108+
if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
109+
runs-on: ubuntu-latest
110+
111+
steps:
112+
# This step is needed to get the size data produced by the compile jobs
113+
- name: Download sketches reports artifacts
114+
uses: actions/download-artifact@v4
115+
with:
116+
# All workflow artifacts will be downloaded to this location.
117+
path: ${{ env.SKETCHES_REPORTS_PATH }}
118+
119+
- uses: arduino/report-size-deltas@v1
120+
with:
121+
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

.github/workflows/report-size-deltas.yml

-24
This file was deleted.

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.idea/

0 commit comments

Comments
 (0)