Added all missing @OverRide annotations

Author: cmaglie

arduino-core/src/cc/arduino/Compiler.java

@@ -516,6 +516,7 @@ private String boardOptions(TargetBoard board) {
    * out from the compiler. The errors are parsed for their contents
    * and line number, which is then reported back to Editor.
    */
+  @Override
   public void message(String s) {
     int i;
 

arduino-core/src/cc/arduino/MyStreamPumper.java

@@ -64,6 +64,7 @@ public MyStreamPumper(final InputStream is, final MessageConsumer messageConsume
    * Copies data from the input stream to the output stream. Terminates as
    * soon as the input stream is closed or an error occurs.
    */
+  @Override
   public void run() {
     synchronized (this) {
       // Just in case this object is reused in the future

arduino-core/src/cc/arduino/contributions/GPGDetachedSignatureVerifier.java

@@ -49,6 +49,7 @@ public GPGDetachedSignatureVerifier(String keyId) {
     this.keyId = keyId;
   }
 
+  @Override
   protected boolean verify(File signedFile, File signature, File publicKey) throws IOException {
     FileInputStream signatureInputStream = null;
     FileInputStream signedFileInputStream = null;

arduino-core/src/cc/arduino/contributions/packages/ContributedPlatform.java

@@ -44,6 +44,7 @@ public abstract class ContributedPlatform extends DownloadableContribution {
 
   public abstract String getArchitecture();
 
+  @Override
   public abstract String getChecksum();
 
   public abstract List<ContributedToolReference> getToolsDependencies();

arduino-core/src/cc/arduino/net/CustomProxySelector.java

@@ -162,6 +162,7 @@ private void setAuthenticator(String username, String password) {
     }
     Authenticator.setDefault(
       new Authenticator() {
+        @Override
         public PasswordAuthentication getPasswordAuthentication() {
           return new PasswordAuthentication(username, actualPassword.toCharArray());
         }

arduino-core/src/cc/arduino/packages/Uploader.java

@@ -152,6 +152,7 @@ public String getFailureMessage() {
     return error;
   }
 
+  @Override
   public void message(String s) {
     // selectively suppress a bunch of avrdude output for AVR109/Caterina that should already be quelled but isn't
     if (!verbose && StringUtils.stringContainsOneOf(s, STRINGS_TO_SUPPRESS)) {

arduino-core/src/cc/arduino/packages/discoverers/SerialDiscovery.java

@@ -52,6 +52,7 @@ public List<BoardPort> listDiscoveredBoards() {
     return getSerialBoardPorts(false);
   }
 
+  @Override
   public List<BoardPort> listDiscoveredBoards(boolean complete) {
     return getSerialBoardPorts(complete);
   }

arduino-core/src/cc/arduino/packages/ssh/NoInteractionUserInfo.java

@@ -39,26 +39,32 @@ public NoInteractionUserInfo(String password) {
     this.password = password;
   }
 
+  @Override
   public String getPassword() {
     return password;
   }
 
+  @Override
   public boolean promptYesNo(String str) {
     return true;
   }
 
+  @Override
   public String getPassphrase() {
     return password;
   }
 
+  @Override
   public boolean promptPassphrase(String message) {
     return true;
   }
 
+  @Override
   public boolean promptPassword(String message) {
     return true;
   }
 
+  @Override
   public void showMessage(String message) {
   }
 

arduino-core/src/cc/arduino/packages/ssh/SSHConfigFileSetup.java

@@ -43,6 +43,7 @@ public SSHConfigFileSetup(SSHClientSetupChainRing nextChainRing) {
     this.nextChainRing = nextChainRing;
   }
 
+  @Override
   public Session setup(BoardPort port, JSch jSch) throws JSchException, IOException {
     String ipAddress = port.getAddress();
     String hostname = port.getBoardName().contains(".local") ? port.getBoardName() : port.getBoardName() + ".local";

arduino-core/src/cc/arduino/packages/uploaders/GenericNetworkUploader.java

@@ -46,6 +46,7 @@ public GenericNetworkUploader(BoardPort port) {
     this.port = port;
   }
 
+  @Override
   public boolean requiresAuthorization() {
     return this.port.getPrefs().get("auth_upload").contentEquals("yes");
   }
@@ -55,6 +56,7 @@ public String getAuthorizationKey() {
     return "runtime.pwd." + this.port.getAddress();
   }
 
+  @Override
   public boolean uploadUsingPreferences(File sourcePath, String buildPath, String className, boolean usingProgrammer, List<String> warningsAccumulator) throws Exception {
     TargetPlatform targetPlatform = BaseNoGui.getTargetPlatform();
     PreferencesMap prefs = PreferencesData.getMap();

arduino-core/src/cc/arduino/packages/uploaders/SSHUploader.java

@@ -63,6 +63,7 @@ public SSHUploader(BoardPort port) {
     this.port = port;
   }
 
+  @Override
   public boolean requiresAuthorization() {
     return true;
   }

arduino-core/src/cc/arduino/packages/uploaders/SerialUploader.java

@@ -61,6 +61,7 @@ public SerialUploader(boolean noUploadPort)
     super(noUploadPort);
   }
 
+  @Override
   public boolean uploadUsingPreferences(File sourcePath, String buildPath, String className, boolean usingProgrammer, List<String> warningsAccumulator) throws Exception {
     // FIXME: Preferences should be reorganized
     TargetPlatform targetPlatform = BaseNoGui.getTargetPlatform();
@@ -347,6 +348,7 @@ private boolean uploadUsingProgrammer(String buildPath, String className) throws
     }
   }
 
+  @Override
   public boolean burnBootloader() throws Exception {
     TargetPlatform targetPlatform = BaseNoGui.getTargetPlatform();
 

arduino-core/src/processing/app/Serial.java

@@ -148,6 +148,7 @@ public void dispose() throws IOException {
     }
   }
 
+  @Override
   public synchronized void serialEvent(SerialPortEvent serialEvent) {
     if (serialEvent.isRXCHAR()) {
       try {

arduino-core/src/processing/app/SketchFile.java

@@ -242,6 +242,7 @@ public boolean isModified() {
     return false;
   }
 
+  @Override
   public boolean equals(Object o) {
     return (o instanceof SketchFile) && file.equals(((SketchFile) o).file);
   }

arduino-core/src/processing/app/debug/MessageSiphon.java

@@ -63,6 +63,7 @@ public MessageSiphon(InputStream stream, MessageConsumer consumer, int lineTimeo
   }
 
 
+  @Override
   public void run() {
     try {
       // process data until we hit EOF; this will happily block

arduino-core/src/processing/app/debug/RunnerException.java

@@ -75,6 +75,7 @@ public RunnerException(Exception e) {
    * Override getMessage() in Throwable, so that I can set 
    * the message text outside the constructor.
    */
+  @Override
   public String getMessage() {
     return message;
   }
@@ -151,6 +152,7 @@ static public final String massage(String msg) {
   */
 
 
+  @Override
   public void printStackTrace() {
     if (showStackTrace) {
       super.printStackTrace();

arduino-core/src/processing/app/debug/Sizer.java

@@ -96,6 +96,7 @@ public long[] computeSize() throws RunnerException {
     return new long[] { textSize, dataSize, eepromSize };
   }
 
+  @Override
   public void message(String s) {
     if (firstLine == null)
       firstLine = s;

arduino-core/src/processing/app/helpers/BasicUserNotifier.java

@@ -9,6 +9,7 @@ public class BasicUserNotifier extends UserNotifier {
    * This is an error that can't be recovered. Use showWarning()
    * for errors that allow P5 to continue running.
    */
+  @Override
   public void showError(String title, String message, Throwable e, int exit_code) {
     if (title == null) title = tr("Error");
 
@@ -18,6 +19,7 @@ public void showError(String title, String message, Throwable e, int exit_code)
     System.exit(exit_code);
   }
 
+  @Override
   public void showMessage(String title, String message) {
     if (title == null) title = tr("Message");
 
@@ -27,6 +29,7 @@ public void showMessage(String title, String message) {
   /**
    * Non-fatal error message with optional stack trace side dish.
    */
+  @Override
   public void showWarning(String title, String message, Exception e) {
     if (title == null) title = tr("Warning");
 

arduino-core/src/processing/app/helpers/filefilters/OnlyDirs.java

@@ -32,6 +32,7 @@
  */
 public class OnlyDirs implements FilenameFilter {
 
+  @Override
   public boolean accept(File dir, String name) {
     if (name.charAt(0) == '.')
       return false;

arduino-core/src/processing/app/helpers/filefilters/OnlyFilesWithExtension.java

@@ -32,6 +32,7 @@ public OnlyFilesWithExtension(String... ext) {
     this.extensions = ext;
   }
 
+  @Override
   public boolean accept(File dir, String name) {
     for (String ext : extensions) {
       if (name.endsWith(ext)) {

arduino-core/src/processing/app/linux/Platform.java

@@ -36,17 +36,20 @@ public class Platform extends processing.app.Platform {
 
   // TODO Need to be smarter here since KDE people ain't gonna like that GTK.
   //      It may even throw a weird exception at 'em for their trouble.
+  @Override
   public void setLookAndFeel() throws Exception {
     GTKLookAndFeelFixer.installGtkPopupBugWorkaround();
   }
 
 
+  @Override
   public File getDefaultSketchbookFolder() throws Exception {
     File home = new File(System.getProperty("user.home"));
     return new File(home, "Arduino");
   }
 
 
+  @Override
   public void openURL(String url) throws Exception {
     if (openFolderAvailable()) {
       String launcher = PreferencesData.get("launcher");
@@ -57,6 +60,7 @@ public void openURL(String url) throws Exception {
   }
 
 
+  @Override
   public boolean openFolderAvailable() {
     if (PreferencesData.get("launcher") != null) {
       return true;
@@ -91,6 +95,7 @@ public boolean openFolderAvailable() {
   }
 
 
+  @Override
   public void openFolder(File file) throws Exception {
     if (openFolderAvailable()) {
       String launcher = PreferencesData.get("launcher");

arduino-core/src/processing/app/macosx/Platform.java

@@ -49,6 +49,7 @@ public class Platform extends processing.app.Platform {
 
   private String osArch;
 
+  @Override
   public void setLookAndFeel() throws Exception {
   }
 
@@ -58,6 +59,7 @@ public Platform() {
     Toolkit.getDefaultToolkit();
   }
 
+  @Override
   public void init() throws Exception {
     super.init();
 
@@ -76,11 +78,13 @@ private void discoverRealOsArch() throws IOException {
   }
 
 
+  @Override
   public File getSettingsFolder() throws Exception {
     return new File(getLibraryFolder(), "Arduino15");
   }
 
 
+  @Override
   public File getDefaultSketchbookFolder() throws Exception {
     return new File(getDocumentsFolder(), "Arduino");
     /*
@@ -98,6 +102,7 @@ public File getDefaultSketchbookFolder() throws Exception {
   }
 
 
+  @Override
   public void openURL(String url) throws Exception {
     Desktop desktop = Desktop.getDesktop();
     if (url.startsWith("http") || url.startsWith("file:")) {
@@ -108,11 +113,13 @@ public void openURL(String url) throws Exception {
   }
 
 
+  @Override
   public boolean openFolderAvailable() {
     return true;
   }
 
 
+  @Override
   public void openFolder(File file) throws Exception {
     //openURL(file.getAbsolutePath());  // handles char replacement, etc
     PApplet.open(file.getAbsolutePath());

arduino-core/src/processing/app/windows/Platform.java

@@ -41,6 +41,7 @@ public class Platform extends processing.app.Platform {
   private File settingsFolder;
   private File defaultSketchbookFolder;
 
+  @Override
   public void init() throws Exception {
     super.init();
 
@@ -108,15 +109,18 @@ protected void checkPath() {
     }
   }
 
+  @Override
   public File getSettingsFolder() {
     return settingsFolder;
   }
 
 
+  @Override
   public File getDefaultSketchbookFolder() throws Exception {
     return defaultSketchbookFolder;
   }
 
+  @Override
   public void openURL(String url) throws Exception {
     // this is not guaranteed to work, because who knows if the
     // path will always be c:\progra~1 et al. also if the user has
@@ -148,11 +152,13 @@ public void openURL(String url) throws Exception {
   }
 
 
+  @Override
   public boolean openFolderAvailable() {
     return true;
   }
 
 
+  @Override
   public void openFolder(File file) throws Exception {
     String folder = file.getAbsolutePath();
 
@@ -180,12 +186,14 @@ public void fixPrefsFilePermissions(File prefsFile) throws IOException {
     //noop
   }
 
+  @Override
   public List<File> postInstallScripts(File folder) {
     List<File> scripts = new LinkedList<>();
     scripts.add(new File(folder, "post_install.bat"));
     return scripts;
   }
 
+  @Override
   public List<File> preUninstallScripts(File folder) {
     List<File> scripts = new LinkedList<>();
     scripts.add(new File(folder, "pre_uninstall.bat"));
@@ -195,9 +203,11 @@ public List<File> preUninstallScripts(File folder) {
   public void symlink(File something, File somewhere) throws IOException, InterruptedException {
   }
 
+  @Override
   public void link(File something, File somewhere) throws IOException, InterruptedException {
   }
 
+  @Override
   public void chmod(File file, int mode) throws IOException, InterruptedException {
   }