Fixed bug in StringReplacer

Author: cmaglie

app/src/processing/app/helpers/StringReplacer.java

@@ -57,8 +57,10 @@ public static String[] quotedSplit(String src, String quoteChars,
     for (String i : src.split(" ")) {
       if (escapingChar == null) {
         // If the first char is not an escape char..
-        String first = i.substring(0, 1);
-        if (!quoteChars.contains(first)) {
+        String first = null;
+        if (i.length() > 0)
+          first = i.substring(0, 1);
+        if (first == null || !quoteChars.contains(first)) {
           if (i.trim().length() != 0 || acceptEmptyArguments)
             res.add(i);
           continue;

app/test/processing/app/helpers/StringReplacerTest.java

@@ -0,0 +1,29 @@
+package processing.app.helpers;
+
+import static org.junit.Assert.assertArrayEquals;
+
+import org.junit.Test;
+
+public class StringReplacerTest {
+  
+  @Test
+  public void quotingCheck() throws Exception {
+    String in = "a\"bc ab'c   'abc abc' ";
+    in += "\"abc abc\" '\"abc abc\"' ";
+    in += "\"'abc abc'\"";
+    String[] res = StringReplacer.quotedSplit(in, "\"'", false);
+    assertArrayEquals(res, new String[] { "a\"bc", "ab'c", "abc abc",
+        "abc abc", "\"abc abc\"", "'abc abc'" });
+  }
+
+  @Test
+  public void quotingCheckWithEmptyStringsAccepted() throws Exception {
+    String in = "a\"bc ab'c   'abc abc' ";
+    in += "\"abc abc\" '\"abc abc\"' ";
+    in += "\"'abc abc'\"";
+    String[] res = StringReplacer.quotedSplit(in, "\"'", true);
+    assertArrayEquals(res, new String[] { "a\"bc", "ab'c", "", "", "abc abc",
+        "abc abc", "\"abc abc\"", "'abc abc'" });
+  }
+  
+}