Skip to content

Commit 04d3a92

Browse files
cmaglieper1234
andcommitted
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent a983fe9 commit 04d3a92

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

rpc/cc/arduino/cli/monitor/v1/monitor.pb.go

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rpc/cc/arduino/cli/monitor/v1/monitor.proto

+9-9
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import "google/protobuf/struct.proto";
2323

2424
// MonitorService provides services for boards monitor.
2525
// DEPRECATION WARNING: MonitorService is deprecated and will be removed in a
26-
// future release. Use CommandService.Monitor and
27-
// CommandService.EnumerateMonitorPortSettings instead.
26+
// future release. Use ArduinoCoreService.Monitor and
27+
// ArduinoCoreService.EnumerateMonitorPortSettings instead.
2828
service MonitorService {
2929
// Open a bidirectional monitor stream. This can be used to implement
3030
// something similar to the Arduino IDE's Serial Monitor.
@@ -37,9 +37,9 @@ service MonitorService {
3737
// must contain a `monitor_config` message to initialize the monitor target.
3838
// All subsequent messages must contain bytes to be sent to the target
3939
// and must not contain a `monitor_config` message.
40-
// DEPRECATION WARNING: StreaminOpenRequest is deprecated and will be removed in
41-
// a future release. Use CommandService.Monitor and
42-
// CommandService.EnumerateMonitorPortSettings instead.
40+
// DEPRECATION WARNING: StreamingOpenRequest is deprecated and will be removed
41+
// in a future release. Use ArduinoCoreService.Monitor and
42+
// ArduinoCoreService.EnumerateMonitorPortSettings instead.
4343
message StreamingOpenRequest {
4444
// Content must be either a monitor config or data to be sent.
4545
oneof content {
@@ -60,8 +60,8 @@ message StreamingOpenRequest {
6060
// Tells the monitor which target to open and provides additional parameters
6161
// that might be needed to configure the target or the monitor itself.
6262
// DEPRECATION WARNING: MonitorConfig is deprecated and will be removed
63-
// in a future release. Use CommandService.Monitor and
64-
// CommandService.EnumerateMonitorPortSettings instead.
63+
// in a future release. Use ArduinoCoreService.Monitor and
64+
// ArduinoCoreService.EnumerateMonitorPortSettings instead.
6565
message MonitorConfig {
6666
enum TargetType {
6767
TARGET_TYPE_SERIAL = 0;
@@ -83,8 +83,8 @@ message MonitorConfig {
8383
}
8484

8585
// DEPRECATION WARNING: StreamingOpenResponse is deprecated and will be removed
86-
// in a future release. Use CommandService.Monitor and
87-
// CommandService.EnumerateMonitorPortSettings instead.
86+
// in a future release. Use ArduinoCoreService.Monitor and
87+
// ArduinoCoreService.EnumerateMonitorPortSettings instead.
8888
message StreamingOpenResponse {
8989
// The data received from the target.
9090
bytes data = 1;

0 commit comments

Comments
 (0)