Skip to content

Commit 2edafc0

Browse files
committed
[breaking] change --timeout flag to --discovery-timeout for consistency
1 parent d8f9bca commit 2edafc0

File tree

2 files changed

+22
-27
lines changed

2 files changed

+22
-27
lines changed

cli/board/list.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,8 @@ func initListCommand() *cobra.Command {
4747
Run: runListCommand,
4848
}
4949

50-
listCommand.Flags().DurationVar(&timeout, "timeout", time.Second,
51-
tr("The connected devices search timeout, raise it if your board doesn't show up e.g.: 10s"))
52-
listCommand.Flags().BoolVarP(&watch, "watch", "w", false,
53-
tr("Command keeps running and prints list of connected boards whenever there is a change."))
50+
listCommand.Flags().DurationVar(&timeout, "discovery-timeout", time.Second, tr("Max time to wait for port discovery, e.g.: 30s, 1m"))
51+
listCommand.Flags().BoolVarP(&watch, "watch", "w", false, tr("Command keeps running and prints list of connected boards whenever there is a change."))
5452

5553
return listCommand
5654
}

i18n/data/en.po

+20-23
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ msgstr "Available Commands:"
216216
msgid "Binary file to upload."
217217
msgstr "Binary file to upload."
218218

219-
#: cli/board/list.go:90
220-
#: cli/board/list.go:128
219+
#: cli/board/list.go:88
220+
#: cli/board/list.go:126
221221
#: cli/board/listall.go:87
222222
#: cli/board/search.go:85
223223
msgid "Board Name"
@@ -373,7 +373,7 @@ msgstr "Clean caches."
373373
msgid "Comma-separated list of additional URLs for the Boards Manager."
374374
msgstr "Comma-separated list of additional URLs for the Boards Manager."
375375

376-
#: cli/board/list.go:53
376+
#: cli/board/list.go:51
377377
msgid "Command keeps running and prints list of connected boards whenever there is a change."
378378
msgstr "Command keeps running and prints list of connected boards whenever there is a change."
379379

@@ -427,16 +427,16 @@ msgstr "Configuring platform"
427427
msgid "Configuring platform."
428428
msgstr "Configuring platform."
429429

430-
#: cli/board/list.go:186
430+
#: cli/board/list.go:184
431431
msgid "Connected"
432432
msgstr "Connected"
433433

434434
#: cli/monitor/monitor.go:177
435435
msgid "Connected to %s! Press CTRL-C to exit."
436436
msgstr "Connected to %s! Press CTRL-C to exit."
437437

438-
#: cli/board/list.go:90
439-
#: cli/board/list.go:128
438+
#: cli/board/list.go:88
439+
#: cli/board/list.go:126
440440
msgid "Core"
441441
msgstr "Core"
442442

@@ -557,7 +557,7 @@ msgstr "Directory where to save generated files. Default is './docs', the direct
557557
msgid "Disable completion description for shells that support it"
558558
msgstr "Disable completion description for shells that support it"
559559

560-
#: cli/board/list.go:187
560+
#: cli/board/list.go:185
561561
msgid "Disconnected"
562562
msgstr "Disconnected"
563563

@@ -659,8 +659,8 @@ msgstr "Error creating sketch archive"
659659
msgid "Error creating sketch: %v"
660660
msgstr "Error creating sketch: %v"
661661

662-
#: cli/board/list.go:74
663-
#: cli/board/list.go:83
662+
#: cli/board/list.go:72
663+
#: cli/board/list.go:81
664664
msgid "Error detecting boards: %v"
665665
msgstr "Error detecting boards: %v"
666666

@@ -984,7 +984,7 @@ msgstr "Error: command description is not supported by %v"
984984
msgid "Error: invalid source code overrides data file: %v"
985985
msgstr "Error: invalid source code overrides data file: %v"
986986

987-
#: cli/board/list.go:90
987+
#: cli/board/list.go:88
988988
msgid "Event"
989989
msgstr "Event"
990990

@@ -1007,8 +1007,8 @@ msgstr "Expected compiled sketch in directory %s, but is a file instead"
10071007

10081008
#: cli/board/attach.go:40
10091009
#: cli/board/details.go:43
1010-
#: cli/board/list.go:90
1011-
#: cli/board/list.go:128
1010+
#: cli/board/list.go:88
1011+
#: cli/board/list.go:126
10121012
#: cli/board/listall.go:87
10131013
#: cli/board/search.go:85
10141014
msgid "FQBN"
@@ -1431,6 +1431,7 @@ msgid "Maintainer: %s"
14311431
msgstr "Maintainer: %s"
14321432

14331433
#: cli/arguments/port.go:75
1434+
#: cli/board/list.go:50
14341435
msgid "Max time to wait for port discovery, e.g.: 30s, 1m"
14351436
msgstr "Max time to wait for port discovery, e.g.: 30s, 1m"
14361437

@@ -1497,7 +1498,7 @@ msgstr "Name: \"%s\""
14971498
msgid "New version"
14981499
msgstr "New version"
14991500

1500-
#: cli/board/list.go:118
1501+
#: cli/board/list.go:116
15011502
msgid "No boards found."
15021503
msgstr "No boards found."
15031504

@@ -1716,8 +1717,8 @@ msgstr "Platform name:"
17161717
msgid "Platform size (bytes):"
17171718
msgstr "Platform size (bytes):"
17181719

1719-
#: cli/board/list.go:90
1720-
#: cli/board/list.go:128
1720+
#: cli/board/list.go:88
1721+
#: cli/board/list.go:126
17211722
msgid "Port"
17221723
msgstr "Port"
17231724

@@ -1775,7 +1776,7 @@ msgstr "Progress {0}"
17751776
msgid "Property '%s' is undefined"
17761777
msgstr "Property '%s' is undefined"
17771778

1778-
#: cli/board/list.go:128
1779+
#: cli/board/list.go:126
17791780
msgid "Protocol"
17801781
msgstr "Protocol"
17811782

@@ -2010,10 +2011,6 @@ msgstr "TOUCH: error during reset: %s"
20102011
msgid "The TCP port the daemon will listen to"
20112012
msgstr "The TCP port the daemon will listen to"
20122013

2013-
#: cli/board/list.go:51
2014-
msgid "The connected devices search timeout, raise it if your board doesn't show up e.g.: 10s"
2015-
msgstr "The connected devices search timeout, raise it if your board doesn't show up e.g.: 10s"
2016-
20172014
#: cli/cli.go:123
20182015
msgid "The custom config file (if not specified the default will be used)."
20192016
msgstr "The custom config file (if not specified the default will be used)."
@@ -2083,8 +2080,8 @@ msgstr "Toolchain type"
20832080
msgid "Turns on verbose mode."
20842081
msgstr "Turns on verbose mode."
20852082

2086-
#: cli/board/list.go:90
2087-
#: cli/board/list.go:128
2083+
#: cli/board/list.go:88
2084+
#: cli/board/list.go:126
20882085
msgid "Type"
20892086
msgstr "Type"
20902087

@@ -2140,7 +2137,7 @@ msgstr "Uninstalls one or more cores and corresponding tool dependencies if no l
21402137
msgid "Uninstalls one or more libraries."
21412138
msgstr "Uninstalls one or more libraries."
21422139

2143-
#: cli/board/list.go:160
2140+
#: cli/board/list.go:158
21442141
msgid "Unknown"
21452142
msgstr "Unknown"
21462143

0 commit comments

Comments
 (0)