Remove hotfix for arduino:samd

Author: alessio-perugini

commands/board/details.go

@@ -66,10 +66,7 @@ func Details(ctx context.Context, req *rpc.BoardDetailsRequest) (*rpc.BoardDetai
 
 	details.DebuggingSupported = boardProperties.ContainsKey("debug.executable") ||
 		boardPlatformRelease.Properties.ContainsKey("debug.executable") ||
-		(boardRefPlatform != nil && boardRefPlatform.Properties.ContainsKey("debug.executable")) ||
-		// HOTFIX: Remove me when the `arduino:samd` core is updated
-		boardPlatformRelease.String() == "arduino:[email protected]" ||
-		boardPlatformRelease.String() == "arduino:[email protected]"
+		(boardRefPlatform != nil && boardRefPlatform.Properties.ContainsKey("debug.executable"))
 
 	details.Package = &rpc.Package{
 		Name:       boardPackage.Name,

commands/debug/debug_info.go

@@ -84,21 +84,6 @@ func getDebugProperties(req *rpc.GetDebugConfigRequest, pme *packagemanager.Expl
 	toolProperties.Merge(platformRelease.RuntimeProperties())
 	toolProperties.Merge(boardProperties)
 
-	// HOTFIX: Remove me when the `arduino:samd` core is updated
-	//         (remember to remove it also in arduino/board/details.go)
-	if !toolProperties.ContainsKey("debug.executable") {
-		if platformRelease.String() == "arduino:[email protected]" || platformRelease.String() == "arduino:[email protected]" {
-			toolProperties.Set("debug.executable", "{build.path}/{build.project_name}.elf")
-			toolProperties.Set("debug.toolchain", "gcc")
-			toolProperties.Set("debug.toolchain.path", "{runtime.tools.arm-none-eabi-gcc-7-2017q4.path}/bin/")
-			toolProperties.Set("debug.toolchain.prefix", "arm-none-eabi-")
-			toolProperties.Set("debug.server", "openocd")
-			toolProperties.Set("debug.server.openocd.path", "{runtime.tools.openocd-0.10.0-arduino7.path}/bin/openocd")
-			toolProperties.Set("debug.server.openocd.scripts_dir", "{runtime.tools.openocd-0.10.0-arduino7.path}/share/openocd/scripts/")
-			toolProperties.Set("debug.server.openocd.script", "{runtime.platform.path}/variants/{build.variant}/{build.openocdscript}")
-		}
-	}
-
 	for _, tool := range pme.GetAllInstalledToolsReleases() {
 		toolProperties.Merge(tool.RuntimeProperties())
 	}

internal/integrationtest/board/board_test.go

@@ -355,8 +355,8 @@ func TestBoardDetails(t *testing.T) {
 		]
 	}`)
 
-	// Download samd core pinned to 1.8.8
-	_, _, err = cli.Run("core", "install", "arduino:[email protected].8")
+	// Download samd core pinned to 1.8.10
+	_, _, err = cli.Run("core", "install", "arduino:[email protected].10")
 	require.NoError(t, err)
 
 	stdout, _, err = cli.Run("board", "details", "-b", "arduino:samd:nano_33_iot", "--format", "json")