Migrate TestCompileWithSketchWithSymlinkSelfloop from test_compile_part_1.py to compile_part_1_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_1_test.go

@@ -19,6 +19,7 @@ import (
 	"crypto/md5"
 	"encoding/hex"
 	"encoding/json"
+	"os"
 	"strings"
 	"testing"
 
@@ -171,3 +172,60 @@ func TestOutputFlagDefaultPath(t *testing.T) {
 	require.NoError(t, err)
 	require.DirExists(t, target.String())
 }
+
+func TestCompileWithSketchWithSymlinkSelfloop(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Install Arduino AVR Boards
+	_, _, err = cli.Run("core", "install", "arduino:[email protected]")
+	require.NoError(t, err)
+
+	sketchName := "CompileIntegrationTestSymlinkSelfLoop"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	stdout, _, err := cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Sketch created in: "+sketchPath.String())
+
+	// create a symlink that loops on himself
+	loopFilePath := sketchPath.Join("loop")
+	err = os.Symlink(loopFilePath.String(), loopFilePath.String())
+	require.NoError(t, err)
+
+	// Build sketch for arduino:avr:uno
+	_, stderr, err := cli.Run("compile", "-b", fqbn, sketchPath.String())
+	// The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
+	// returning a different error detailed message
+	require.Contains(t, string(stderr), "Error opening sketch:")
+	require.Error(t, err)
+
+	sketchName = "CompileIntegrationTestSymlinkDirLoop"
+	sketchPath = cli.SketchbookDir().Join(sketchName)
+
+	// Create a test sketch
+	stdout, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Sketch created in: "+sketchPath.String())
+
+	// create a symlink that loops on the upper level
+	loopDirPath := sketchPath.Join("loop_dir")
+	err = loopDirPath.Mkdir()
+	require.NoError(t, err)
+	loopDirSymlinkPath := loopDirPath.Join("loop_dir_symlink")
+	err = os.Symlink(loopDirPath.String(), loopDirSymlinkPath.String())
+	require.NoError(t, err)
+
+	// Build sketch for arduino:avr:uno
+	_, stderr, err = cli.Run("compile", "-b", fqbn, sketchPath.String())
+	// The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
+	// returning a different error detailed message
+	require.Contains(t, string(stderr), "Error opening sketch:")
+	require.Error(t, err)
+}

test/test_compile_part_1.py

@@ -25,56 +25,6 @@
 from .common import running_on_ci
 
 
-def test_compile_with_sketch_with_symlink_selfloop(run_command, data_dir):
-    # Init the environment explicitly
-    run_command(["core", "update-index"])
-
-    # Install Arduino AVR Boards
-    run_command(["core", "install", "arduino:[email protected]"])
-
-    sketch_name = "CompileIntegrationTestSymlinkSelfLoop"
-    sketch_path = os.path.join(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    result = run_command(["sketch", "new", sketch_path])
-    assert result.ok
-    assert "Sketch created in: {}".format(sketch_path) in result.stdout
-
-    # create a symlink that loops on himself
-    loop_file_path = os.path.join(sketch_path, "loop")
-    os.symlink(loop_file_path, loop_file_path)
-
-    # Build sketch for arduino:avr:uno
-    result = run_command(["compile", "-b", fqbn, sketch_path])
-    # The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
-    # returning a different error detailed message
-    assert "Error opening sketch:" in result.stderr
-    assert not result.ok
-
-    sketch_name = "CompileIntegrationTestSymlinkDirLoop"
-    sketch_path = os.path.join(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    result = run_command(["sketch", "new", sketch_path])
-    assert result.ok
-    assert "Sketch created in: {}".format(sketch_path) in result.stdout
-
-    # create a symlink that loops on the upper level
-    loop_dir_path = os.path.join(sketch_path, "loop_dir")
-    os.mkdir(loop_dir_path)
-    loop_dir_symlink_path = os.path.join(loop_dir_path, "loop_dir_symlink")
-    os.symlink(loop_dir_path, loop_dir_symlink_path)
-
-    # Build sketch for arduino:avr:uno
-    result = run_command(["compile", "-b", fqbn, sketch_path])
-    # The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
-    # returning a different error detailed message
-    assert "Error opening sketch:" in result.stderr
-    assert not result.ok
-
-
 def test_compile_blacklisted_sketchname(run_command, data_dir):
     """
     Compile should ignore folders named `RCS`, `.git` and the likes, but