Skip to content

Commit a20234b

Browse files
Migrate TestAddMultipleArguments from test_config.py to config_test.go
1 parent 8f69253 commit a20234b

File tree

2 files changed

+36
-26
lines changed

2 files changed

+36
-26
lines changed

internal/integrationtest/config/config_test.go

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,3 +328,39 @@ func TestAddSingleArgument(t *testing.T) {
328328
require.NoError(t, err)
329329
requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[\"https://example.com\"]")
330330
}
331+
332+
func TestAddMultipleArguments(t *testing.T) {
333+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
334+
defer env.CleanUp()
335+
336+
// Create a config file
337+
_, _, err := cli.Run("config", "init", "--dest-dir", ".")
338+
require.NoError(t, err)
339+
340+
// Verifies no additional urls are present
341+
stdout, _, err := cli.Run("config", "dump", "--format", "json")
342+
require.NoError(t, err)
343+
requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[]")
344+
345+
// Adds multiple URLs at the same time
346+
urls := [2]string{
347+
"https://example.com/package_example_index.json",
348+
"https://example.com/yet_another_package_example_index.json",
349+
}
350+
_, _, err = cli.Run("config", "add", "board_manager.additional_urls", urls[0], urls[1])
351+
require.NoError(t, err)
352+
353+
// Verifies URL has been saved
354+
stdout, _, err = cli.Run("config", "dump", "--format", "json")
355+
require.NoError(t, err)
356+
requirejson.Query(t, stdout, ".board_manager | .additional_urls | length", "2")
357+
requirejson.Contains(t, stdout, `
358+
{
359+
"board_manager": {
360+
"additional_urls": [
361+
"https://example.com/package_example_index.json",
362+
"https://example.com/yet_another_package_example_index.json"
363+
]
364+
}
365+
}`)
366+
}

test/test_config.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -17,32 +17,6 @@
1717
import yaml
1818

1919

20-
def test_add_multiple_arguments(run_command):
21-
# Create a config file
22-
assert run_command(["config", "init", "--dest-dir", "."])
23-
24-
# Verifies no additional urls are present
25-
result = run_command(["config", "dump", "--format", "json"])
26-
assert result.ok
27-
settings_json = json.loads(result.stdout)
28-
assert [] == settings_json["board_manager"]["additional_urls"]
29-
30-
# Adds multiple URLs at the same time
31-
urls = [
32-
"https://example.com/package_example_index.json",
33-
"https://example.com/yet_another_package_example_index.json",
34-
]
35-
assert run_command(["config", "add", "board_manager.additional_urls"] + urls)
36-
37-
# Verifies URL has been saved
38-
result = run_command(["config", "dump", "--format", "json"])
39-
assert result.ok
40-
settings_json = json.loads(result.stdout)
41-
assert 2 == len(settings_json["board_manager"]["additional_urls"])
42-
assert urls[0] in settings_json["board_manager"]["additional_urls"]
43-
assert urls[1] in settings_json["board_manager"]["additional_urls"]
44-
45-
4620
def test_add_on_unsupported_key(run_command):
4721
# Create a config file
4822
assert run_command(["config", "init", "--dest-dir", "."])

0 commit comments

Comments
 (0)