Add pre-uninstall flags to CLI arguments

Author: MatteoPologruto

internal/cli/arguments/post_install.go renamed to internal/cli/arguments/pre_post_script.go

@@ -21,33 +21,47 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// PostInstallFlags contains flags data used by the core install and the upgrade command
+// PrePostScriptsFlags contains flags data used by the core install and the upgrade command
 // This is useful so all flags used by commands that need
 // this information are consistent with each other.
-type PostInstallFlags struct {
-	runPostInstall  bool // force the execution of installation scripts
-	skipPostInstall bool // skip the execution of installation scripts
+type PrePostScriptsFlags struct {
+	runPostInstall   bool // force the execution of installation scripts
+	skipPostInstall  bool // skip the execution of installation scripts
+	runPreUninstall  bool // force the execution of pre uninstall scripts
+	skipPreUninstall bool // skip the execution of pre uninstall scripts
 }
 
 // AddToCommand adds flags that can be used to force running or skipping
 // of post installation scripts
-func (p *PostInstallFlags) AddToCommand(cmd *cobra.Command) {
+func (p *PrePostScriptsFlags) AddToCommand(cmd *cobra.Command) {
 	cmd.Flags().BoolVar(&p.runPostInstall, "run-post-install", false, tr("Force run of post-install scripts (if the CLI is not running interactively)."))
 	cmd.Flags().BoolVar(&p.skipPostInstall, "skip-post-install", false, tr("Force skip of post-install scripts (if the CLI is running interactively)."))
+	cmd.Flags().BoolVar(&p.runPreUninstall, "run-pre-uninstall", false, tr("Force run of pre-uninstall scripts (if the CLI is not running interactively)."))
+	cmd.Flags().BoolVar(&p.skipPreUninstall, "skip-pre-uninstall", false, tr("Force skip of pre-uninstall scripts (if the CLI is running interactively)."))
 }
 
 // GetRunPostInstall returns the run-post-install flag value
-func (p *PostInstallFlags) GetRunPostInstall() bool {
+func (p *PrePostScriptsFlags) GetRunPostInstall() bool {
 	return p.runPostInstall
 }
 
 // GetSkipPostInstall returns the skip-post-install flag value
-func (p *PostInstallFlags) GetSkipPostInstall() bool {
+func (p *PrePostScriptsFlags) GetSkipPostInstall() bool {
 	return p.skipPostInstall
 }
 
+// GetRunPreUninstall returns the run-post-install flag value
+func (p *PrePostScriptsFlags) GetRunPreUninstall() bool {
+	return p.runPreUninstall
+}
+
+// GetSkipPreUninstall returns the skip-post-install flag value
+func (p *PrePostScriptsFlags) GetSkipPreUninstall() bool {
+	return p.skipPreUninstall
+}
+
 // DetectSkipPostInstallValue returns true if a post install script must be run
-func (p *PostInstallFlags) DetectSkipPostInstallValue() bool {
+func (p *PrePostScriptsFlags) DetectSkipPostInstallValue() bool {
 	if p.GetRunPostInstall() {
 		logrus.Info("Will run post-install by user request")
 		return false
@@ -64,3 +78,22 @@ func (p *PostInstallFlags) DetectSkipPostInstallValue() bool {
 	logrus.Info("Running from console, will run post-install by default")
 	return false
 }
+
+// DetectSkipPreUninstallValue returns true if a post install script must be run
+func (p *PrePostScriptsFlags) DetectSkipPreUninstallValue() bool {
+	if p.GetRunPreUninstall() {
+		logrus.Info("Will run pre-uninstall by user request")
+		return false
+	}
+	if p.GetSkipPreUninstall() {
+		logrus.Info("Will skip pre-uninstall by user request")
+		return true
+	}
+
+	if !configuration.IsInteractive {
+		logrus.Info("Not running from console, will skip pre-uninstall by default")
+		return true
+	}
+	logrus.Info("Running from console, will run pre-uninstall by default")
+	return false
+}

internal/cli/core/install.go

@@ -31,7 +31,7 @@ import (
 
 func initInstallCommand() *cobra.Command {
 	var noOverwrite bool
-	var postInstallFlags arguments.PostInstallFlags
+	var postInstallFlags arguments.PrePostScriptsFlags
 	installCommand := &cobra.Command{
 		Use:   fmt.Sprintf("install %s:%s[@%s]...", tr("PACKAGER"), tr("ARCH"), tr("VERSION")),
 		Short: tr("Installs one or more cores and corresponding tool dependencies."),
@@ -56,7 +56,7 @@ func initInstallCommand() *cobra.Command {
 	return installCommand
 }
 
-func runInstallCommand(args []string, postInstallFlags arguments.PostInstallFlags, noOverwrite bool) {
+func runInstallCommand(args []string, postInstallFlags arguments.PrePostScriptsFlags, noOverwrite bool) {
 	inst := instance.CreateAndInit()
 	logrus.Info("Executing `arduino-cli core install`")
 

internal/cli/core/upgrade.go

@@ -32,7 +32,7 @@ import (
 )
 
 func initUpgradeCommand() *cobra.Command {
-	var postInstallFlags arguments.PostInstallFlags
+	var postInstallFlags arguments.PrePostScriptsFlags
 	upgradeCommand := &cobra.Command{
 		Use:   fmt.Sprintf("upgrade [%s:%s] ...", tr("PACKAGER"), tr("ARCH")),
 		Short: tr("Upgrades one or all installed platforms to the latest version."),

internal/cli/upgrade/upgrade.go

@@ -31,7 +31,7 @@ var tr = i18n.Tr
 
 // NewCommand creates a new `upgrade` command
 func NewCommand() *cobra.Command {
-	var postInstallFlags arguments.PostInstallFlags
+	var postInstallFlags arguments.PrePostScriptsFlags
 	upgradeCommand := &cobra.Command{
 		Use:     "upgrade",
 		Short:   tr("Upgrades installed cores and libraries."),