Skip to content

Commit 3f0a6b7

Browse files
author
Akos Kitta
committed
chore: use Node.js >=18.17.0
remove `msvs_version` npm config on win32 Ref: nodejs/node-gyp#2822 Signed-off-by: Akos Kitta <[email protected]>
1 parent 1290433 commit 3f0a6b7

File tree

5 files changed

+9
-13
lines changed

5 files changed

+9
-13
lines changed

.github/workflows/build.yml

+2-6
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ jobs:
8585
- name: Checkout
8686
uses: actions/checkout@v3
8787

88-
- name: Install Node.js 16.14
88+
- name: Install Node.js 18.17
8989
uses: actions/setup-node@v3
9090
with:
91-
node-version: '16.14'
91+
node-version: '18.17'
9292
registry-url: 'https://registry.npmjs.org'
9393
cache: 'yarn'
9494

@@ -131,10 +131,6 @@ jobs:
131131
export CSC_FOR_PULL_REQUEST=true
132132
fi
133133
134-
if [ "${{ runner.OS }}" = "Windows" ]; then
135-
npm config set msvs_version 2017 --global
136-
fi
137-
138134
npx node-gyp install
139135
yarn install --immutable
140136

.github/workflows/check-i18n-task.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ jobs:
5858
- name: Checkout repository
5959
uses: actions/checkout@v3
6060

61-
- name: Install Node.js 16.14
61+
- name: Install Node.js 18.17
6262
uses: actions/setup-node@v3
6363
with:
64-
node-version: '16.14'
64+
node-version: '18.17'
6565
registry-url: 'https://registry.npmjs.org'
6666
cache: 'yarn'
6767

.github/workflows/i18n-nightly-push.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
- name: Checkout
1717
uses: actions/checkout@v3
1818

19-
- name: Install Node.js 16.14
19+
- name: Install Node.js 18.17
2020
uses: actions/setup-node@v3
2121
with:
22-
node-version: '16.14'
22+
node-version: '18.17'
2323
registry-url: 'https://registry.npmjs.org'
2424
cache: 'yarn'
2525

.github/workflows/i18n-weekly-pull.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
- name: Checkout
1717
uses: actions/checkout@v3
1818

19-
- name: Install Node.js 16.14
19+
- name: Install Node.js 18.17
2020
uses: actions/setup-node@v3
2121
with:
22-
node-version: '16.14'
22+
node-version: '18.17'
2323
registry-url: 'https://registry.npmjs.org'
2424
cache: 'yarn'
2525

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "AGPL-3.0-or-later",
88
"private": true,
99
"engines": {
10-
"node": ">=16.14.0 <17"
10+
"node": ">=18.17.0 <21"
1111
},
1212
"devDependencies": {
1313
"@theia/cli": "1.39.0",

0 commit comments

Comments
 (0)