Skip to content

Commit 5260a07

Browse files
use master cli for testing, await in upload finish
1 parent 6710f35 commit 5260a07

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

arduino-ide-extension/package.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,11 @@
155155
],
156156
"arduino": {
157157
"cli": {
158-
"version": "0.23.0"
158+
"version": {
159+
"owner": "arduino",
160+
"repo": "arduino-cli",
161+
"commitish": "master"
162+
}
159163
},
160164
"fwuploader": {
161165
"version": "2.2.0"

arduino-ide-extension/src/node/arduino-firmware-uploader-impl.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ export class ArduinoFirmwareUploaderImpl implements ArduinoFirmwareUploader {
9090
} catch (e) {
9191
throw e;
9292
} finally {
93-
this.monitorManager.notifyUploadFinished(board, port);
93+
await this.monitorManager.notifyUploadFinished(board, port);
9494
return output;
9595
}
9696
}

arduino-ide-extension/src/node/core-service-impl.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
224224
throw new Error(errorMessage);
225225
} finally {
226226
this.uploading = false;
227-
this.monitorManager.notifyUploadFinished(board, port);
227+
await this.monitorManager.notifyUploadFinished(board, port);
228228
}
229229
}
230230

@@ -288,7 +288,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
288288
throw new Error(errorMessage);
289289
} finally {
290290
this.uploading = false;
291-
this.monitorManager.notifyUploadFinished(board, port);
291+
await this.monitorManager.notifyUploadFinished(board, port);
292292
}
293293
}
294294

0 commit comments

Comments
 (0)