fix: remove obsolete select programmer contrib

due to CLI API changes, IDE2 cannot behave reactively, and perform a
command on error. `GetDebugConfigRequest` params must be valid.

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

@@ -361,7 +361,6 @@ import { TerminalFrontendContribution as TheiaTerminalFrontendContribution } fro
 import { SelectionService } from '@theia/core/lib/common/selection-service';
 import { CommandService } from '@theia/core/lib/common/command';
 import { CorePreferences } from '@theia/core/lib/browser/core-preferences';
-import { SelectProgrammer } from './contributions/select-programmer';
 import { AutoSelectProgrammer } from './contributions/auto-select-programmer';
 import { HostedPluginSupport } from './hosted/hosted-plugin-support';
 
@@ -759,7 +758,6 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
   Contribution.configure(bind, CreateCloudCopy);
   Contribution.configure(bind, UpdateArduinoState);
   Contribution.configure(bind, BoardsDataMenuUpdater);
-  Contribution.configure(bind, SelectProgrammer);
   Contribution.configure(bind, AutoSelectProgrammer);
 
   bindContributionProvider(bind, StartupTaskProvider);

arduino-ide-extension/src/browser/contributions/debug.ts

@@ -3,11 +3,7 @@ import { MenuModelRegistry } from '@theia/core/lib/common/menu/menu-model-regist
 import { nls } from '@theia/core/lib/common/nls';
 import { MaybePromise } from '@theia/core/lib/common/types';
 import { inject, injectable } from '@theia/core/shared/inversify';
-import {
-  SelectManually,
-  noBoardSelected,
-  noSketchOpened,
-} from '../../common/nls';
+import { noBoardSelected, noSketchOpened } from '../../common/nls';
 import {
   BoardDetails,
   BoardIdentifier,
@@ -17,7 +13,6 @@ import {
   SketchRef,
   isBoardIdentifierChangeEvent,
   isCompileSummary,
-  isProgrammer,
 } from '../../common/protocol';
 import { BoardsDataStore } from '../boards/boards-data-store';
 import { BoardsServiceProvider } from '../boards/boards-service-provider';
@@ -225,43 +220,10 @@ export class Debug extends SketchContribution {
       const result = await this.debug(params);
       return Boolean(result);
     } catch (err) {
-      const yes = nls.localize('vscode/extensionsUtils/yes', 'Yes');
-      const sketchUri = await this.fileSystemExt.getUri(params.sketchPath);
-      const sketch = SketchRef.fromUri(sketchUri);
-      if (err instanceof Error && /missing programmer/gi.test(err.message)) {
-        const answer = await this.messageService.warn(
-          nls.localize(
-            'arduino/debug/programmerNotSelected',
-            'The debugger requires a programmer. Do you want to select a programmer? You can select it manually from the Tools > Programmer menu.'
-          ),
-          SelectManually,
-          yes
-        );
-        if (answer === yes) {
-          const result = await this.commandService.executeCommand(
-            'arduino-select-programmer'
-          );
-          if (isProgrammer(result)) {
-            return this.startDebug();
-          }
-        }
-      } else if (await this.isSketchNotVerifiedError(err, sketch)) {
-        const answer = await this.messageService.error(
-          nls.localize(
-            'arduino/debug/sketchIsNotCompiled',
-            "Sketch '{0}' must be verified before starting a debug session.",
-            sketch.name
-          ),
-          yes
-        );
-        if (answer === yes) {
-          this.commandService.executeCommand('arduino-verify-sketch');
-        }
-      } else {
-        this.messageService.error(
-          err instanceof Error ? err.message : String(err)
-        );
-      }
+      console.error(err);
+      this.messageService.error(
+        err instanceof Error ? err.message : String(err)
+      );
     }
     return false;
   }

arduino-ide-extension/src/browser/contributions/select-programmer.ts

@@ -9,6 +9,7 @@ import { DisposableCollection } from '@theia/core/lib/common/disposable';
 import { CommandEvent, CommandRegistry } from '@theia/core/lib/common/command';
 import { Emitter } from '@theia/core/lib/common/event';
 import { deepClone } from '@theia/core/lib/common/objects';
+import { wait } from '@theia/core/lib/common/promise-util';
 import { Mutable } from '@theia/core/lib/common/types';
 import {
   Container,
@@ -35,18 +36,17 @@ import { noBoardSelected, noSketchOpened } from '../../common/nls';
 import {
   BoardsConfigChangeEvent,
   BoardsPackage,
+  CompileSummary,
   ExecutableService,
   type BoardDetails,
   type Programmer,
   type Sketch,
-  CompileSummary,
 } from '../../common/protocol';
 import {
   BoardsConfig,
   emptyBoardsConfig,
 } from '../../common/protocol/boards-service';
 import { bindSketchesContribution } from './browser-test-bindings';
-import { wait } from '@theia/core/lib/common/promise-util';
 import { aPackage } from './fixtures/boards';
 
 disableJSDOM();