Skip to content

Commit 89a8513

Browse files
committed
Merge branch 'main' into theia-1.19
# Conflicts: # arduino-ide-extension/src/browser/dialogs/settings/settings-component.tsx
2 parents caec4e2 + 6e34a27 commit 89a8513

File tree

3 files changed

+0
-30
lines changed

3 files changed

+0
-30
lines changed

arduino-ide-extension/src/browser/dialogs/settings/settings-component.tsx

-17
Original file line numberDiff line numberDiff line change
@@ -294,17 +294,6 @@ export class SettingsComponent extends React.Component<
294294
'Editor Quick Suggestions'
295295
)}
296296
</label>
297-
<label className="flex-line">
298-
<input
299-
type="checkbox"
300-
checked={this.state.enableLsLogs}
301-
onChange={this.enableLsLogsDidChange}
302-
/>
303-
{nls.localize(
304-
'arduino/preferences/languageServerLogging',
305-
'Enable language server logging'
306-
)}
307-
</label>
308297
<div className="flex-line">
309298
{nls.localize(
310299
'arduino/preferences/additionalManagerURLs',
@@ -527,12 +516,6 @@ export class SettingsComponent extends React.Component<
527516
this.setState({ autoScaleInterface: event.target.checked });
528517
};
529518

530-
protected enableLsLogsDidChange = (
531-
event: React.ChangeEvent<HTMLInputElement>
532-
) => {
533-
this.setState({ enableLsLogs: event.target.checked });
534-
};
535-
536519
protected interfaceScaleDidChange = (
537520
event: React.ChangeEvent<HTMLInputElement>
538521
) => {

arduino-ide-extension/src/browser/dialogs/settings/settings.tsx

-12
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const WINDOW_SETTING = `${ARDUINO_SETTING}.window`;
2727
// const IDE_SETTING = `${ARDUINO_SETTING}.ide`;
2828
const COMPILE_SETTING = `${ARDUINO_SETTING}.compile`;
2929
const UPLOAD_SETTING = `${ARDUINO_SETTING}.upload`;
30-
const LANGUAGE_SETTING = `${ARDUINO_SETTING}.language`;
3130
const SKETCHBOOK_SETTING = `${ARDUINO_SETTING}.sketchbook`;
3231
const AUTO_SCALE_SETTING = `${WINDOW_SETTING}.autoScale`;
3332
const ZOOM_LEVEL_SETTING = `${WINDOW_SETTING}.zoomLevel`;
@@ -36,7 +35,6 @@ const COMPILE_VERBOSE_SETTING = `${COMPILE_SETTING}.verbose`;
3635
const COMPILE_WARNINGS_SETTING = `${COMPILE_SETTING}.warnings`;
3736
const UPLOAD_VERBOSE_SETTING = `${UPLOAD_SETTING}.verbose`;
3837
const UPLOAD_VERIFY_SETTING = `${UPLOAD_SETTING}.verify`;
39-
const LANGUAGE_LOG_SETTING = `${LANGUAGE_SETTING}.log`;
4038
const SHOW_ALL_FILES_SETTING = `${SKETCHBOOK_SETTING}.showAllFiles`;
4139

4240
export interface Settings extends Index {
@@ -55,7 +53,6 @@ export interface Settings extends Index {
5553
compilerWarnings: CompilerWarnings; // `arduino.compile.warnings`
5654
verboseOnUpload: boolean; // `arduino.upload.verbose`
5755
verifyAfterUpload: boolean; // `arduino.upload.verify`
58-
enableLsLogs: boolean; // `arduino.language.log`
5956
sketchbookShowAllFiles: boolean; // `arduino.sketchbook.showAllFiles`
6057

6158
sketchbookPath: string; // CLI
@@ -118,7 +115,6 @@ export class SettingsService {
118115
compilerWarnings,
119116
verboseOnUpload,
120117
verifyAfterUpload,
121-
enableLsLogs,
122118
sketchbookShowAllFiles,
123119
cliConfig,
124120
] = await Promise.all([
@@ -144,7 +140,6 @@ export class SettingsService {
144140
this.preferenceService.get<any>(COMPILE_WARNINGS_SETTING, 'None'),
145141
this.preferenceService.get<boolean>(UPLOAD_VERBOSE_SETTING, true),
146142
this.preferenceService.get<boolean>(UPLOAD_VERIFY_SETTING, true),
147-
this.preferenceService.get<boolean>(LANGUAGE_LOG_SETTING, true),
148143
this.preferenceService.get<boolean>(SHOW_ALL_FILES_SETTING, false),
149144
this.configService.getConfiguration(),
150145
]);
@@ -164,7 +159,6 @@ export class SettingsService {
164159
compilerWarnings,
165160
verboseOnUpload,
166161
verifyAfterUpload,
167-
enableLsLogs,
168162
sketchbookShowAllFiles,
169163
additionalUrls,
170164
sketchbookPath,
@@ -245,7 +239,6 @@ export class SettingsService {
245239
compilerWarnings,
246240
verboseOnUpload,
247241
verifyAfterUpload,
248-
enableLsLogs,
249242
sketchbookPath,
250243
additionalUrls,
251244
network,
@@ -312,11 +305,6 @@ export class SettingsService {
312305
verifyAfterUpload,
313306
PreferenceScope.User
314307
),
315-
this.preferenceService.set(
316-
LANGUAGE_LOG_SETTING,
317-
enableLsLogs,
318-
PreferenceScope.User
319-
),
320308
this.preferenceService.set(
321309
SHOW_ALL_FILES_SETTING,
322310
sketchbookShowAllFiles,

i18n/en.json

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
"verifyAfterUpload": "Verify code after upload",
5858
"checkForUpdates": "Check for updates on startup",
5959
"editorQuickSuggestions": "Editor Quick Suggestions",
60-
"languageServerLogging": "Enable language server logging",
6160
"additionalManagerURLs": "Additional Boards Manager URLs",
6261
"noProxy": "No proxy",
6362
"manualProxy": "Manual proxy configuration",

0 commit comments

Comments
 (0)