Skip to content

Commit 43d385b

Browse files
committed
Improve test coverage of SS002 rule function
Previously the test data for the unit tests of this function did not provide full coverage of all valid sketch filename formats.
1 parent 8072751 commit 43d385b

File tree

7 files changed

+3
-1
lines changed

7 files changed

+3
-1
lines changed

internal/rule/rulefunction/sketch_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func TestSketchNameMismatch(t *testing.T) {
7575
func TestProhibitedCharactersInSketchFileName(t *testing.T) {
7676
testTables := []sketchRuleFunctionTestTable{
7777
{"Has prohibited characters", "ProhibitedCharactersInFileName", ruleresult.Fail, "^Prohibited CharactersInFileName.h$"},
78-
{"No prohibited characters", "Valid", ruleresult.Pass, ""},
78+
{"No prohibited characters", "AllowedCharactersInFilenames", ruleresult.Pass, ""},
7979
}
8080

8181
checkSketchRuleFunction(ProhibitedCharactersInSketchFileName, testTables, t)

internal/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/1LeadingNumber.ino

Whitespace-only changes.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
void setup() {}
2+
void loop() {}

internal/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/Contains-Hyphen.ino

Whitespace-only changes.

internal/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/Contains.Dot.ino

Whitespace-only changes.

internal/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/ContainsNumber1.ino

Whitespace-only changes.

internal/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/Contains_Underscore.ino

Whitespace-only changes.

0 commit comments

Comments
 (0)