Configure Windows release tasks to include firmware in generated package #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool performs three distinct operations: - Check the board's operating system version, and if outdated flash the new version. - Check the board's BLE firmware version, and if outdated flash the new version. - Flash the user application binary. For this reason, the release package must contain the operating system and BLE firmware files in addition to the tool executable. These files are stored in subfolders under the `firmwares` folder of the repository. Previously, the `zip` command used to generate the release packages for Windows hosts was not correctly configured to recurse into the folder when generating the archive. This resulted in the release package only containing an empty folder where the firmware files should have been located. This caused uploads to fail when the target board had an outdated operating system or BLE firmware version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool performs three distinct operations:
For this reason, the release package must contain the operating system and BLE firmware files in addition to the tool executable. These files are stored in subfolders under the
firmwaresfolder of the repository.Previously, the
zipcommand used to generate the release packages for Windows hosts was not correctly configured to recurse into the folder when generating the archive. This resulted in the release package only containing an empty folder where the firmware files should have been located. This caused uploads to fail when the target board had an outdated operating system or BLE firmware version.In order to facilitate the review, I performed a test release with the updated tasks in my fork:
Workflow run: https://github.com/per1234/arduino101load/actions/runs/15080113345
Generated release (you can check the content of the generated release packages by downloading them from the release assets): https://github.com/per1234/arduino101load/releases/tag/0.0.0-rc.3
Fixes #7