You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Avoid workflow conditional reliance on specific runner
In order to catch platform-specific bugs, the "Test Go" workflow uses a job matrix to run the tests on multiple runners.
The step that uploads code coverage data to Codecov is intended to run only during the Linux job. The runner name
`ubuntu-latest` was used in the conditional to accomplish this. However, I'm observing that sometimes it is necessary or
desirable to pin a specific runner version (e.g., `ubuntu-18.04`). The accompanying adjustment to the conditional might
be forgotten and there would not be any obvious sign that the coverage upload had stopped, nor why.
So I'm thinking the better approach would be to use the general `runner.os` context item to identify the Linux job in the
conditional. This will not be ideal in the event multiple Linux runners are added to the workflow's job matrix, but I
haven't observed that in practice and the double upload shouldn't cause any problems.
0 commit comments