Skip to content

Commit 6764ae6

Browse files
authored
Merge pull request #1 from angular/master
merge
2 parents 53a3bf6 + 704123a commit 6764ae6

30 files changed

+6886
-7010
lines changed

docs/app/e2e/app.scenario.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var webdriver = require('protractor/node_modules/selenium-webdriver');
3+
var webdriver = require('selenium-webdriver');
44

55
describe('docs.angularjs.org', function() {
66

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
@ngdoc error
2+
@name $compile:badrestrict
3+
@fullName Invalid Directive Restrict
4+
@description
5+
6+
This error occurs when the restrict property of a directive is not valid.
7+
8+
The directive restrict property must be a string including one of more of the following characters:
9+
* E (element)
10+
* A (attribute)
11+
* C (class)
12+
* M (comment)
13+
14+
For example:
15+
```javascript
16+
restrict: 'E'
17+
restrict: 'EAC'
18+
```
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
@ngdoc error
2+
@name $compile:multilink
3+
@fullName Linking Element Multiple Times
4+
@description
5+
6+
This error occurs when a single element is linked more then once.
7+
8+
For example, if an element is compiled and linked twice without cloning:
9+
```
10+
var linker = $compile(template);
11+
linker($scope); //=> ok
12+
linker($scope); //=> multilink error
13+
```
14+
15+
Linking an element as a clone multiple times is ok:
16+
```
17+
var linker = $compile(template);
18+
linker($scope, function() { ... }); //=> ok
19+
linker($scope, function() { ... }); //=> ok
20+
```
21+
22+
However once an element has been linked it can not be re-linked as a clone:
23+
```
24+
var linker = $compile(template);
25+
linker($scope); //=> ok
26+
linker($scope, function() { ... }); //=> multilink error
27+
```

docs/content/error/$compile/noident.ngdoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ For example, the following directives are valid:
1616
directive("okay", function() {
1717
return {
1818
bindToController: true,
19-
controller: "myCtrl as $ctrl"
19+
controller: "myCtrl as $ctrl",
2020
scope: {
2121
text: "@text"
2222
}

docs/content/guide/external-resources.ngdoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ You can find a larger list of Angular external libraries at [ngmodules.org](http
140140
[Pluralsite (3 courses)](http://www.pluralsight.com/training/Courses/Find?highlight=true&searchTerm=angularjs),
141141
[Tuts+](https://tutsplus.com/course/easier-js-apps-with-angular/),
142142
[lynda.com](http://www.lynda.com/AngularJS-tutorials/Up-Running-AngularJS/133318-2.html),
143-
[WintellectNOW (4 lessons)](http://www.wintellectnow.com/Course/Detail/mastering-angularjs)
143+
[WintellectNOW (4 lessons)](http://www.wintellectnow.com/Course/Detail/mastering-angularjs),
144+
[Packt](https://www.packtpub.com/web-development/angularjs-maintaining-web-applications)
144145
* **Paid onsite:**
145146
[angularbootcamp.com](http://angularbootcamp.com/)
146-

karma-shared.conf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ module.exports = function(config, specificOptions) {
170170
'/someSanitizedUrl',
171171
'/{{testUrl}}'
172172
];
173-
var log4js = require('./node_modules/karma/node_modules/log4js');
174-
var layouts = require('./node_modules/karma/node_modules/log4js/lib/layouts');
173+
var log4js = require('log4js');
174+
var layouts = require('log4js/lib/layouts');
175175
var originalConfigure = log4js.configure;
176176
log4js.configure = function(log4jsConfig) {
177177
var consoleAppender = log4jsConfig.appenders.shift();

lib/grunt/plugins.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ module.exports = function(grunt) {
3939

4040

4141
grunt.registerTask('docs', 'create angular docs', function() {
42-
var gruntProc = shelljs.exec('"node_modules/.bin/gulp" --gulpfile docs/gulpfile.js');
42+
var gruntProc = shelljs.exec('npm run gulp -- --gulpfile docs/gulpfile.js');
4343
if (gruntProc.code !== 0) {
4444
throw new Error('doc generation failed');
4545
}

lib/grunt/utils.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
var fs = require('fs');
44
var shell = require('shelljs');
55
var grunt = require('grunt');
6-
var spawn = require('child_process').spawn;
6+
var spawn = require('cross-spawn');
77

88
var CSP_CSS_HEADER = '/* Include this file in your html if you are using the CSP mode. */\n\n';
99

@@ -15,7 +15,7 @@ module.exports = {
1515
var reporters = grunt.option('reporters');
1616
var noColor = grunt.option('no-colors');
1717
var port = grunt.option('port');
18-
var p = spawn('node', ['node_modules/karma/bin/karma', 'start', config,
18+
var p = spawn('./node_modules/.bin/karma', ['start', config,
1919
singleRun ? '--single-run=true' : '',
2020
reporters ? '--reporters=' + reporters : '',
2121
browsers ? '--browsers=' + browsers : '',
@@ -38,7 +38,7 @@ module.exports = {
3838
done();
3939
return;
4040
}
41-
var p = spawn('node', ['node_modules/protractor/bin/webdriver-manager', 'update']);
41+
var p = spawn('./node_modules/.bin/webdriver-manager', ['update']);
4242
p.stdout.pipe(process.stdout);
4343
p.stderr.pipe(process.stderr);
4444
p.on('exit', function(code) {
@@ -54,7 +54,7 @@ module.exports = {
5454
var sauceBuild = grunt.option('capabilities.build');
5555
var browser = grunt.option('browser');
5656
var specs = grunt.option('specs');
57-
var args = ['node_modules/protractor/bin/protractor', config];
57+
var args = [config];
5858
if (sauceUser) args.push('--sauceUser=' + sauceUser);
5959
if (sauceKey) args.push('--sauceKey=' + sauceKey);
6060
if (tunnelIdentifier) args.push('--capabilities.tunnel-identifier=' + tunnelIdentifier);
@@ -65,7 +65,7 @@ module.exports = {
6565
}
6666

6767

68-
var p = spawn('node', args);
68+
var p = spawn('./node_modules/.bin/protractor', args);
6969
p.stdout.pipe(process.stdout);
7070
p.stderr.pipe(process.stderr);
7171
p.on('exit', function(code) {

0 commit comments

Comments
 (0)