Merge pull request #232 from aws-samples/2025-02-25-java-sqs-batch-bugfix

yualexan · web-flow · commit eeed424673b4 · 2025-02-25T13:47:52.000-08:00
Fix bug where messageId may not be instantiated in try block
diff --git a/lambda-function-sqs-report-batch-item-failures/example.java b/lambda-function-sqs-report-batch-item-failures/example.java
@@ -17,10 +17,9 @@ public SQSBatchResponse handleRequest(SQSEvent sqsEvent, Context context) {
          for (SQSEvent.SQSMessage message : sqsEvent.getRecords()) {
              try {
                  //process your message
-                 messageId = message.getMessageId();
              } catch (Exception e) {
                  //Add failed message identifier to the batchItemFailures list
-                 batchItemFailures.add(new SQSBatchResponse.BatchItemFailure(messageId));
+                 batchItemFailures.add(new SQSBatchResponse.BatchItemFailure(message.getMessageId()));
              }
          }
          return new SQSBatchResponse(batchItemFailures);

Original file line number	Diff line number	Diff line change
`@@ -17,10 +17,9 @@ public SQSBatchResponse handleRequest(SQSEvent sqsEvent, Context context) {`
`17`	`17`	`for (SQSEvent.SQSMessage message : sqsEvent.getRecords()) {`
`18`	`18`	`try {`
`19`	`19`	`//process your message`
`20`		`- messageId = message.getMessageId();`
`21`	`20`	`} catch (Exception e) {`
`22`	`21`	`//Add failed message identifier to the batchItemFailures list`
`23`		`- batchItemFailures.add(new SQSBatchResponse.BatchItemFailure(messageId));`
	`22`	`+ batchItemFailures.add(new SQSBatchResponse.BatchItemFailure(message.getMessageId()));`
`24`	`23`	`}`
`25`	`24`	`}`
`26`	`25`	`return new SQSBatchResponse(batchItemFailures);`