Skip to content

Commit 1d5ac8f

Browse files
committed
Sonar quebe test bug fixed
1 parent f9fc676 commit 1d5ac8f

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/document/DefaultEnhancedDocument.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ private <T> T fromAttributeValue(AttributeValue attributeValue, EnhancedType<T>
263263
if (type.rawClass().equals(AttributeValue.class)) {
264264
return (T) attributeValue;
265265
}
266-
return (T) converterForClass(type, attributeConverterChain).transformTo(attributeValue);
266+
return converterForClass(type, attributeConverterChain).transformTo(attributeValue);
267267
}
268268

269269
public static class DefaultBuilder implements EnhancedDocument.Builder {

services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/mapper/DocumentTableSchema.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@
6868
*/
6969
@SdkPublicApi
7070
public final class DocumentTableSchema implements TableSchema<EnhancedDocument> {
71-
72-
private static final AttributeValue NULL_ATTRIBUTE_VALUE = AttributeValue.fromNul(true);
7371
private final TableMetadata tableMetadata;
7472
private final List<AttributeConverterProvider> attributeConverterProviders;
7573

services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/document/EnhancedDocumentTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ void enhancedDocumentGetters() {
9898
}
9999

100100
@Test
101-
public void enhancedDocWithNestedListAndMaps() {
101+
void enhancedDocWithNestedListAndMaps() {
102102
/**
103103
* No attributeConverters supplied, in this case it uses the {@link DefaultAttributeConverterProvider} and does not error
104104
*/
@@ -130,8 +130,8 @@ public void enhancedDocWithNestedListAndMaps() {
130130
assertThat(simpleDoc.getString("HashKey")).isEqualTo("abcdefg123");
131131
assertThat(simpleDoc.isNull("nullKey")).isTrue();
132132

133-
assertThat(simpleDoc.getNumber("numberKey")).isNotEqualTo(2.0);
134-
assertThat(simpleDoc.getNumber("numberKey").doubleValue()).isEqualTo(2.0);
133+
assertThat(simpleDoc.getNumber("numberKey")).isEqualTo(SdkNumber.fromDouble(2.0));
134+
assertThat(simpleDoc.getNumber("numberKey").bigDecimalValue().compareTo(BigDecimal.valueOf(2.0))).isEqualTo(0);
135135

136136
assertThat(simpleDoc.getBytes("sdkByte")).isEqualTo(SdkBytes.fromUtf8String("a"));
137137
assertThat(simpleDoc.getBoolean("booleanKey")).isTrue();

0 commit comments

Comments
 (0)