Skip to content

Commit 6ae0dd4

Browse files
authored
Stop populating SessionMode by default for the SDK-created S3 express sessions. (#5845)
This value already matched the service-side default, and was already not sent by most SDK languages.
1 parent f93b1e6 commit 6ae0dd4

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "bugfix",
3+
"category": "Amazon S3",
4+
"contributor": "",
5+
"description": "Stopped populating SessionMode by default for the SDK-created S3 express sessions. This value already matched the service-side default, and was already not sent by most SDK languages."
6+
}

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/s3express/S3ExpressIdentityCache.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import software.amazon.awssdk.services.s3.S3Client;
3030
import software.amazon.awssdk.services.s3.model.CreateSessionRequest;
3131
import software.amazon.awssdk.services.s3.model.SessionCredentials;
32-
import software.amazon.awssdk.services.s3.model.SessionMode;
3332
import software.amazon.awssdk.services.s3.s3express.S3ExpressSessionCredentials;
3433
import software.amazon.awssdk.utils.cache.lru.LruCache;
3534

@@ -103,7 +102,6 @@ SessionCredentials getCredentials(S3ExpressIdentityKey key, IdentityProvider<Aws
103102
Duration requestApiCallTimeout = clientSetTimeoutIfExists(serviceClientConfiguration).orElse(DEFAULT_API_CALL_TIMEOUT);
104103

105104
return CreateSessionRequest.builder().bucket(bucket)
106-
.sessionMode(SessionMode.READ_WRITE)
107105
.overrideConfiguration(o -> o.credentialsProvider(provider)
108106
.apiCallTimeout(requestApiCallTimeout)).build();
109107
}

services/s3/src/test/java/software/amazon/awssdk/services/s3/functionaltests/S3ExpressTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ private static void verifyGetObject(S3ExpressSessionAuth s3ExpressSessionAuth) {
264264

265265
private static void verifySessionHeaders() {
266266
verify(1, getRequestedFor(urlMatching("/.*session"))
267-
.withHeader("x-amz-create-session-mode", equalTo("ReadWrite"))
267+
.withoutHeader("x-amz-create-session-mode")
268268
.withHeader("x-amz-content-sha256", equalTo("UNSIGNED-PAYLOAD")));
269269
}
270270

0 commit comments

Comments
 (0)