Removed ctor and added a builder

Author: joviegas

services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/document/DefaultEnhancedDocument.java

@@ -51,7 +51,7 @@
 /**
  * Default implementation of {@link EnhancedDocument}. This class is used by SDK to create Enhanced Documents.
  * Internally saves attributes in an attributeValueMap which can be written to DynamoDB without further conversion.
- * The attribute values are retrieve by converting attributeValue from attributeValueMap at the time of get.
+ * The attribute values are retrieved by converting attributeValue from attributeValueMap at the time of get.
  */
 @Immutable
 @SdkInternalApi
@@ -75,10 +75,6 @@ public DefaultEnhancedDocument(DefaultBuilder builder) {
         attributeConverterProviders = ChainConverterProvider.create(builder.attributeConverterProviders);
     }
 
-    public static DefaultEnhancedDocument fromAttributeValueMap(Map<String, AttributeValue> attributeValueMap) {
-        return new DefaultEnhancedDocument(attributeValueMap);
-    }
-
     public static DefaultBuilder builder() {
         return new DefaultBuilder();
 
@@ -495,6 +491,11 @@ public Builder json(String json) {
         public EnhancedDocument build() {
             return new DefaultEnhancedDocument(this);
         }
+
+        public DefaultBuilder attributeValueMap(Map<String, AttributeValue> attributeValueMap) {
+            this.attributeValueMap = attributeValueMap != null ? new LinkedHashMap<>(attributeValueMap) : null;
+            return this;
+        }
     }
 
     @Override

services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/document/DefaultEnhancedDocumentTest.java

@@ -320,8 +320,11 @@ void validate_BuilderMethodsOfDefaultDocument(AttributeStringValueMap expectedMa
     void validate_GetterMethodsOfDefaultDocument(AttributeStringValueMap expectedMap,
                                                  DefaultEnhancedDocument enhancedDocument,
                                                  String expectedJson) {
-        DefaultEnhancedDocument defaultEnhancedDocument = DefaultEnhancedDocument
-            .fromAttributeValueMap(expectedMap.getAttributeValueMap());
+        DefaultEnhancedDocument defaultEnhancedDocument = (DefaultEnhancedDocument) DefaultEnhancedDocument
+            .builder()
+            .attributeValueMap(expectedMap.getAttributeValueMap())
+            .addAttributeConverterProvider(DefaultAttributeConverterProvider.create())
+            .build();
 
        validateAttributeValueMapAndDocument(expectedMap, defaultEnhancedDocument);
         assertThat(defaultEnhancedDocument.toJson()).isEqualTo(expectedJson);
@@ -357,8 +360,11 @@ void nullDocumentGet(){
         assertThat(nullDocument.isNull("nonNull")).isFalse();
         assertThat(nullDocument.getAttributeValueMap().get("nullDocument")).isEqualTo(AttributeValue.fromNul(true));
 
-        DefaultEnhancedDocument document = DefaultEnhancedDocument.fromAttributeValueMap(
-            mapFromSimpleKeyAttributeValue(Pair.of("nullAttribute", AttributeValue.fromNul(true))));
+        DefaultEnhancedDocument document = (DefaultEnhancedDocument) DefaultEnhancedDocument
+            .builder().attributeValueMap(
+                mapFromSimpleKeyAttributeValue(Pair.of("nullAttribute", AttributeValue.fromNul(true))))
+            .addAttributeConverterProvider(DefaultAttributeConverterProvider.create())
+            .build();
 
         assertThat(document.isNull("nullAttribute")).isTrue();
     }