Skip to content

Create new DefaultCredentialsProvider instance every time instead of … #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

zoewangg
Copy link
Contributor

…using single instance

Motivation and Context

Fix #5881

Currently, if credentials provider is not provided in AWS CRT-based S3 client, DefaultCredentialsProvider will be created by DefaultCredentialsProvider.create(). However, it returns a singleton instance. This means that if a customers is creating and closing a new client per request, the singleton instance may get closed and all subsequent requests would fail, causing Connection pool shut down to be thrown

Modifications

Use DefaultCredentialsProvider.builder().build() (new instance) instead of DefaultCredentialsProvider.create() (singleton) to initialize credentials provider if it's not provided.

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner April 30, 2025 23:00
Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
51.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@zoewangg zoewangg added this pull request to the merge queue May 2, 2025
Merged via the queue into master with commit b8a7432 May 2, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing STS token using CRT client fails
3 participants