Create new DefaultCredentialsProvider instance every time instead of … #6080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using single instance
Motivation and Context
Fix #5881
Currently, if credentials provider is not provided in AWS CRT-based S3 client, DefaultCredentialsProvider will be created by
DefaultCredentialsProvider.create()
. However, it returns a singleton instance. This means that if a customers is creating and closing a new client per request, the singleton instance may get closed and all subsequent requests would fail, causingConnection pool shut down
to be thrownModifications
Use
DefaultCredentialsProvider.builder().build()
(new instance) instead ofDefaultCredentialsProvider.create()
(singleton) to initialize credentials provider if it's not provided.Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License